gmt_updates supports very few architectures

[sebastic]

Description of the problem

The Debian package for 6.7.0 failed to build on several architectures, because gmt_update only supports amd64 & arm64:

https://buildd.debian.org/status/package.php?p=gmt

Should we remove the gmt package from all the other architectures or should gmt_update only warn about other architectures?

System information

• Operating system: Debian unstable
• GMT version (gmt --version): 6.7.0

[joa-quim]

Bas, sorry for this (wasn't caught by the Linux CIs). As is gmt_update is a non documented program that was only tested on Windows. It is safe to remove its build recipes for all Linux for 6.7.0 version. Does this answer your question?

[sebastic]

Not building gmt_update is also an option indeed.

I've added this patch for that:

--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -603,16 +603,19 @@ target_link_libraries (gshhg_version ${N
 # script2verbatim for removing comments, replacing -ps from example scripts
 add_executable (script2verbatim script2verbatim.c)

-# gmt_update — standalone binary updater. Deliberately does NOT link against
-# libgmt/pslib so that those DLLs are NOT held open by this process and can be
-# replaced on Windows. Uses only libcurl + an embedded public-domain SHA-256.
-add_executable (gmt_update gmt_update.c sha256.c)
-target_include_directories (gmt_update PRIVATE ${CURL_INCLUDE_DIRS})
-target_link_libraries (gmt_update ${CURL_LIBRARIES})
-if (WIN32)
-       target_link_libraries (gmt_update rstrtmgr)
-endif (WIN32)
-install (TARGETS gmt_update RUNTIME DESTINATION ${GMT_BINDIR} COMPONENT Runtime)
+option(WITH_GMT_UPDATE "Build and install gmt_update executable" ON)
+if (WITH_GMT_UPDATE)
+       # gmt_update — standalone binary updater. Deliberately does NOT link against
+       # libgmt/pslib so that those DLLs are NOT held open by this process and can be
+       # replaced on Windows. Uses only libcurl + an embedded public-domain SHA-256.
+       add_executable (gmt_update gmt_update.c sha256.c)
+       target_include_directories (gmt_update PRIVATE ${CURL_INCLUDE_DIRS})
+       target_link_libraries (gmt_update ${CURL_LIBRARIES})
+       if (WIN32)
+               target_link_libraries (gmt_update rstrtmgr)
+       endif (WIN32)
+       install (TARGETS gmt_update RUNTIME DESTINATION ${GMT_BINDIR} COMPONENT Runtime)
+endif()


 ##

[joa-quim]

I wonder if we couldn't adopt it too but we already created the 6.7.0 tag.

[sebastic]

No need to change 6.7.0, simply address the issue in 6.7.1/6.8.0.

[joa-quim]

OK, thanks. We still have some issues to solve in creating the tarballs.