Dev 6.18.20 alertl minor fixes - #303
Open
sathyapk wants to merge 3 commits into
Open
Conversation
Remove "return 0;" from the void inline stubs apml_unregister_sbrmi_device(), apml_unregister_sbtsi_device(), and apml_put_device_node() Reviewed-by: Akshay Gupta <akshay.gupta@amd.com> Signed-off-by: Sathya Priya Kumar <sathyapriya.k@amd.com>
misc: amd-apml: fix modular SBRMI build Build sbrmi.o and sbrmi-common.o into one apml_sbrmi.ko module instead of two separate modules, fixing modpost unresolved symbols. No driver logic changes; only the module packaging is corrected. Reviewed-by: Akshay Gupta <akshay.gupta@amd.com> Signed-off-by: Sathya Priya Kumar <sathyapriya.k@amd.com>
Use int for bus_num and unsigned int for regmap status reads/writes to match I2C/I3C bus identifiers and the regmap API. Reviewed-by: Akshay Gupta <akshay.gupta@amd.com> Signed-off-by: Sathya Priya Kumar <sathyapriya.k@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix amd-apml build and type issues on the branch so APML Alert_L and modular SBRMI build cleanly and report bus/status values correctly.