[PWGEM] Fix potential mismatches between data and MC table size - #17411
Merged
Conversation
In skimmerGammaCalo merged the filling of the reconstruction data table and the MC info table into one function to ensure both are filled at the same time using the exact same cuts. In associateMCinfoPhoton added additionl collision check for filling the mclabels tables. Before it was only checked that the reco collision has a matching mc_collision nothing else. However, when creating the `fEventLabels` look up map for the association of the collisions isSelected() function is called. This could result in EmMcParticles poiting to garbage EMMCEventIds.
mhemmer-cern
requested review from
alibuild,
amaringarcia,
dsekihat,
hscheid,
jokonig and
reygers
as code owners
August 11, 2026 11:55
mhemmer-cern
changed the title
|
O2 linter results: ❌ 9 errors, |
mhemmer-cern
changed the title
mhemmer-cern
enabled auto-merge (squash)
August 11, 2026 14:40
alibuild
approved these changes
Aug 11, 2026
alibuild
left a comment
alibuild
left a comment
Collaborator
There was a problem hiding this comment.
Auto-approving on behalf of @mhemmer-cern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In skimmerGammaCalo merged the filling of the reconstruction data table and the MC info table into one function to ensure both are filled at the same time using the exact same cuts. Before this commit, MC was missing the maxEnergy and exotic cluster cut.
Also now, one only needs one of the two new MC process and no longer needs Reco + MC to have both informations available.
In associateMCinfoPhoton added additional collision check for filling the mclabels tables. Before it was only checked that the reco collision has a matching mc_collision nothing else. However, when creating the
fEventLabelslook up map for the association of the collisions theisSelected()function is called. This could result in EmMcParticles pointing to garbage EMMCEventIds. The usage ofisSelected()can now be turned on and off via the new configuseIsSelected.Also added extra protection against cases where a collisionId was not added to
fEventLabelswhich will results in a warning log message.