feat: contribution ledger and ring milestones (1.3.0) - #43
Open
tastybento wants to merge 5 commits into
Open
Conversation
Add /ch ledger [days] showing per-member contributions (blocks, chunks, rings) from the activity counters foundation. Enhance ring milestones: record RINGS_COMPLETED activity, show next-ring progress in /ch chunks, add island_next_ring_remaining placeholder, and ship default trophies for rings 2 and 3. Closes #7, closes #3. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0114k1MQ9RoWNXKW4NHiwLxC
Unquoted colons in the description field break SnakeYAML's scanner, causing InvalidDescriptionException on Pladdon load. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0114k1MQ9RoWNXKW4NHiwLxC
- Boss bar status now prepends the island's active title when set - /ch title (no args) toggles the title on/off instead of listing - /ch title list shows earned trophies (was the old no-args behavior) - Trophy award message now says "toggle it on and off using /ch title" - Renamed default trophy titles to island-appropriate names: Ring Bearer → The Outpost, Ring Champion → The Stronghold, Ring Master → The Citadel, Block Breaker → The Forge Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0114k1MQ9RoWNXKW4NHiwLxC
BentoBox's getTranslationOrNothing does variable replacement inside its own pipeline, but [island-title] was not being substituted. Do the replacement as a post-step on the translated string instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0114k1MQ9RoWNXKW4NHiwLxC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/ch ledger [days]command shows each team member's contributions (blocks broken, chunks claimed, rings completed) from the activity counters foundation. Supports an optional day-window filter for recent activity.RINGS_COMPLETEDactivity (visible in ledger and feeding trophy conditions)./ch chunksshows progress toward the next ring ("Ring 2: 12/16 chunks to go"). Newisland_next_ring_remainingplaceholder for scoreboards. Defaulttrophies.ymlexpanded with trophies for rings 2 and 3.Closes #7, closes #3.
Test plan
mvn test— all 737 tests pass (including 5 newIslandLedgerCommandTestand 5 newChunkManagerTestring-remaining tests)/ch ledgerwith team members who have broken blocks and claimed chunks — verify member rows and totals/ch ledger 7to verify the day-window filter/ch chunksand verify the new "Ring N: X/Y chunks to go" line appears when a ring is incompleteRINGS_COMPLETEDcounter increments%chunkblock_island_next_ring_remaining%placeholder returns the correct count🤖 Generated with Claude Code
https://claude.ai/code/session_0114k1MQ9RoWNXKW4NHiwLxC