Skip to content

Feat/add u256 - #30

Open
aritkulova wants to merge 21 commits into
devfrom
feat/add-u256
Open

Feat/add u256#30
aritkulova wants to merge 21 commits into
devfrom
feat/add-u256

Conversation

@aritkulova

@aritkulova aritkulova commented Aug 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • This PR suggests a bug fix and I've added the necessary tests.
  • This PR introduces a new feature and I've discussed the update in an Issue or with the team.
  • This PR is just a minor change like a typo fix.

@aritkulova
added full_add_128;
8a5c65f 
refactored normalize_to_threshold to calculate_normalizer_base_64;
made algorithm_d function private
@aritkulova
added functions for uint256
3f9910c
@aritkulova
added U256Wrapper for u256 tests;
cb05ec9 
added tests for u256
@aritkulova
fixed typo
655d450
@aritkulova
aritkulova requested a review from Hrom131 August 1, 2026 13:50
@aritkulova aritkulova self-assigned this Aug 1, 2026
@Hrom131
Hrom131 changed the base branch from master to dev August 3, 2026 09:26
LesterEvSe
LesterEvSe requested changes Aug 6, 2026
View reviewed changes

@LesterEvSe LesterEvSe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have the eq_128 function, but I couldn't find eq_256. So it would be better to add it as well

Comment thread simf/lib/u256.simf
Comment thread tests/common/helper.rs Outdated
Comment thread simf/lib/u256.simf Outdated
Comment thread tests/u256_test_arithmetic_2.rs Outdated
@LesterEvSe

LesterEvSe commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

The u256_test_arithmetic_N naming makes it hard to tell which operations a file covers and where a given check lives. Let's split the tests by operation instead. Rather than the current naming, I suggest:

u256_test_compare — is_zero / lt / le / eq
u256_test_add — split / add / add_128
u256_test_mul — sub / mul
u256_test_div — div_mod_256_64 / div_mod_256_128 / div_mod_256 / div_256

LesterEvSe
LesterEvSe reviewed Aug 6, 2026
View reviewed changes
Comment thread tests/common/helper.rs
Comment thread simf/u128_test_arithmetic.simf Outdated
@aritkulova

aritkulova commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

We also have the eq_128 function, but I couldn't find eq_256. So it would be better to add it as well

We have a jet for eq_256, which is missing for u128

@LesterEvSe
LesterEvSe self-requested a review August 10, 2026 11:38
LesterEvSe
LesterEvSe requested changes Aug 10, 2026
View reviewed changes
Comment thread simf/lib/u256.simf Outdated
Comment thread simf/lib/u256.simf Outdated
Comment thread simf/lib/u256.simf Outdated
Comment thread simf/lib/u256.simf Outdated
Comment thread tests/u128_test_arithmetic.rs Outdated
@aritkulova
aritkulova requested a review from LesterEvSe August 10, 2026 15:49
LesterEvSe
LesterEvSe approved these changes Aug 11, 2026
View reviewed changes

@LesterEvSe LesterEvSe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7ae47db; tested locally with simplex test --test-threads 8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LesterEvSe LesterEvSe LesterEvSe approved these changes
@Hrom131 Hrom131 Awaiting requested review from Hrom131

Assignees

@aritkulova aritkulova

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aritkulova @LesterEvSe