Skip to content

fix: move useMemo before early return (hooks rules) #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 7 commits into from
Aug 13, 2026
Merged

fix: move useMemo before early return (hooks rules) #1948

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6023fde
fix: resolve 6 validate-specs errors from dev merge (em-dashes, blast…
Flotapponnier Aug 13, 2026
a65c1eb
fix: remove duplicate provider-registry entries (coinbase/kraken/etc …
Flotapponnier Aug 13, 2026
d0abc34
fix: remove duplicate logo-manifest and brand entries from dev merge
Flotapponnier Aug 13, 2026
933c71b
fix: add sol unit to views.ts and snapshot.ts UnitSchema
Flotapponnier Aug 13, 2026
d34b490
fix: wrap Date.now() in useMemo to satisfy react-compiler purity rule
Flotapponnier Aug 13, 2026
620ecdb
fix: move useMemo before early return in exec-bench-table (hooks order)
Flotapponnier Aug 13, 2026
efba412
merge: resolve exec-bench-table conflict (keep useMemo before early r…
Flotapponnier Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions src/components/exec-bench-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ export function ExecBenchTable({
data: ExecLeaderboardResponse | null;
}) {
const [win, setWin] = useState<Window>("24h");
const stale = useMemo(
() =>
data?.updatedAt
? Date.now() - new Date(data.updatedAt).getTime() > 3 * 60 * 60 * 1000
: false,
[data?.updatedAt]
);

if (!data) {
return (
Expand All @@ -42,14 +49,6 @@ export function ExecBenchTable({
(b.windows[win]?.txCount ?? 0) - (a.windows[win]?.txCount ?? 0),
);

const stale = useMemo(
() =>
data.updatedAt
? Date.now() - new Date(data.updatedAt).getTime() > 3 * 60 * 60 * 1000
: false,
[data.updatedAt]
);

return (
<div className="card rounded-xl overflow-hidden">
<div className="px-4 sm:px-6 pt-4 pb-0 flex items-end justify-between gap-4 flex-wrap border-b border-rule">
Expand Down
Loading