fix(a11y): enlarge interactive targets to 24×24 (A9) - #59
Conversation
Grow composer attach/send hit areas and the session delete control so they meet WCAG 2.5.8 without enlarging the icon glyphs. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CSS increases session delete, composer attachment, and composer send controls to minimum 24×24 pixel interaction targets. The session delete icon is centered with inline flexbox. Vitest tests parse 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/dom/target-size-a9.test.js`:
- Around line 25-32: Update the regular expression in pxValue to require a CSS
declaration boundary before the requested property name, preventing width or
height from matching inside min-width or min-height. Preserve the existing value
parsing and null behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5bbfc67c-8b38-4fca-a46a-ef5e26a9f514
📒 Files selected for processing (2)
public/app.csstests/dom/target-size-a9.test.js
Require a declaration boundary before the property so width/height do not match inside min-width/min-height. Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
Closes #53 ([a11y][A9]). Composer attach/send controls and the session delete button were below the WCAG 2.2 AA 24×24 CSS pixel minimum (18×18 and 22×22). Hit areas are grown via
min-width/min-height(and explicit 24×24 on delete); icon glyphs stay smaller.Changes
In
public/app.css:.composer__icon-btnand.composer__send-btngetmin-width/min-height: 24px(toolbar SVGs remainheight: 18px).session-item__deletemoves from 22×22 to 24×24, with flex centering so the 12×12 trash icon stays centeredSidebar resizer widening left as optional polish (keyboard alternative already exists). No DS / A6 / D7 changes.
Test plan
npm test(CSS hit-area guards intests/dom/target-size-a9.test.js)Made with Cursor