a11y | A10 persistent conversation heading - #78
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe change adds a persistent, visually hidden conversation-level Possibly related PRs
Suggested reviewers: Comment |
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #65 (A10). The only
<h1>was empty-state "What's on your mind?", so once messages appeared the outline started at the sidebar<h2>History.Changes
<h1 id="conversationHeading">inside<main>, kept in sync with the active session title (New conversationuntil a title exists).<p>with the same visual class, so the document has exactly one<h1>in both empty and populated states.Test plan
npm testh1(session title or "New conversation"); "What's on your mind?" is visible but not a headingh1, now the session title; empty state goneh1to "New conversation"page-has-heading-oneis not in the empty-state scan today)