Skip to content

a11y | A14+A15 page language and translated chrome names - #80

Merged
BrianGenisio merged 1 commit into
mainfrom
fix/a11y-a14-a15-i18n-lang-labels
Aug 12, 2026
Merged

a11y | A14+A15 page language and translated chrome names#80
BrianGenisio merged 1 commit into
mainfrom
fix/a11y-a14-a15-i18n-lang-labels

Conversation

@BrianGenisio

Copy link
Copy Markdown
Contributor

Summary

Closes #68 (A14) and #69 (A15). UI strings can already render in Spanish from i18n/es.json, but <html lang="en"> never changed and chrome aria-labels stayed English.

Also removes git conflict markers that landed in wave-4-plan.md on main via #79.

Changes

  • /api/config attaches htmlLang (es / en) when a catalog matches config.language. applyChatConfigUI writes that onto <html lang>.
  • Static landmark and control names in index.html are rewritten through t() on config apply. Attachment remove uses t('Remove {name}', …) instead of a template literal.
  • New keys in i18n/en.json and i18n/es.json. Settings modal / slider / dropdown defaults stay English until D9 + a submodule bump.

Test plan

  • npm test
  • Set "language": "es" (or "Spanish") in chat-config.json, reload: <html lang="es">, VoiceOver/rotor names in Spanish for sidebar, composer, resizer, prompt
  • Default / no language: <html lang="en">, English names unchanged
  • Attach a file and confirm the remove button name is Quitar {filename} / Remove {filename}
  • Confirm axe baseline does not grow

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 30 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 36b7ca9a-ff29-4346-904f-48cc7933e792

📥 Commits

Reviewing files that changed from the base of the PR and between 81fe35f and a720bf3.

📒 Files selected for processing (9)
  • a11y-audits/8-5-26/wave-4-plan.md
  • i18n/en.json
  • i18n/es.json
  • lib/helpers.js
  • public/app.js
  • server.js
  • tests/dom/render.test.js
  • tests/helpers.test.js
  • tests/server.test.js

Comment @coderabbitai help to get the list of available commands.

@BrianGenisio
BrianGenisio merged commit ba8b8f0 into main Aug 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[a11y][A14] lang=en hardcoded despite Spanish catalog

1 participant