Skip to content

London | ITP-MAY-2026 | Ebrahim Moqbel | sprint 2 | Wireframe to Web code - #1242

Open
Ebrahim-Moqbel wants to merge 29 commits into
CodeYourFuture:mainfrom
Ebrahim-Moqbel:feature/wireframe
Open

London | ITP-MAY-2026 | Ebrahim Moqbel | sprint 2 | Wireframe to Web code#1242
Ebrahim-Moqbel wants to merge 29 commits into
CodeYourFuture:mainfrom
Ebrahim-Moqbel:feature/wireframe

Conversation

@Ebrahim-Moqbel

@Ebrahim-Moqbel Ebrahim-Moqbel commented May 9, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have a added content and images with layout standing by CSS and HTML

@netlify

netlify Bot commented May 9, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 2c397b4
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a7318c17fd49000088180a9
😎 Deploy Preview https://deploy-preview-1242--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 91 (🔴 down 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@RaihanSharif

Copy link
Copy Markdown

Wireframe must be in sprint 2. They changed it from the Jan cohort.

@Poonam-raj

Copy link
Copy Markdown
Contributor

@Ebrahim-Moqbel - I believe you still need to add a "Needs Review" label to this work for it to be reviewed by a volunteer and submitted

@Poonam-raj

Copy link
Copy Markdown
Contributor

Wireframe must be in sprint 2. They changed it from the Jan cohort.

^^ Agreed with this, your PR title doesn't reflect the sprint that Wireframe to Web Code actually sits in now

@Ebrahim-Moqbel

Copy link
Copy Markdown
Author

Thank you I will update it accordingly

@Ebrahim-Moqbel Ebrahim-Moqbel changed the title London | ITP-MAY-2026 | Ebrahim Moqbel | sprint 1 | Wireframe to Web code London | ITP-MAY-2026 | Ebrahim Moqbel | sprint 2 | Wireframe to Web code Jun 5, 2026
@github-actions

This comment has been minimized.

@Ebrahim-Moqbel Ebrahim-Moqbel added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@Ebrahim-Moqbel Ebrahim-Moqbel added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@Sambuxc Sambuxc added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 5, 2026

@Sambuxc Sambuxc left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi please take a look at the questions I've raised in your file changes. Thanks :)

Comment thread Wireframe/index.html Outdated
Comment thread Wireframe/index.html Outdated
Comment thread Wireframe/style.css Outdated
@Sambuxc Sambuxc added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 5, 2026
Comment thread Wireframe/index.html
@Ebrahim-Moqbel Ebrahim-Moqbel added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Aug 5, 2026
Sambuxc

This comment was marked as resolved.

@Sambuxc Sambuxc added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 6, 2026
@Sambuxc

Sambuxc commented Aug 6, 2026

Copy link
Copy Markdown

Well done for resolving the final points.

This looks good now and has passed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants