West-Midlands | 26-ITP-May | Maryam Janjua | Sprint 3 | Implement and Rewrite Tests - #1603
Open
maryam-devio wants to merge 2 commits into
Open
Conversation
maryam-devio
added
📅 Sprint 3
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
maryam-devio
changed the title
maryam-devio
added
the
Needs Review
cjyuan
reviewed
Aug 10, 2026
Comment on lines
+15
to
+20
| if(numerator < denominator){ | ||
| return true; | ||
| } | ||
| else{ | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
What are the expected return value of these function calls?
isProperFraction(-1, 0)
isProperFraction(-1, -5);
isProperFraction(-1, 5);
On what authoritative source do you base your definition of a proper fraction on?
Comment on lines
+38
to
+42
| const rank = Number(card.slice(0,-1)); | ||
| const suit = card.slice(-1); | ||
| if(rank >= 2 && rank <=10 && ["♠","♥", "♦", "♣"].includes(suit)){ | ||
| return rank; | ||
| } |
Contributor
There was a problem hiding this comment.
In JavaScript, strings that represent valid numeric literals in the language can be safely converted to equivalent numbers. For examples, "0x02", "2.1", or "0002".
Does your function return the value you expected from each of the following function calls?
getCardValue("0x02♠");
getCardValue("2.1♠");
getCardValue("0002♠");
| expect(getAngleType(181)).toEqual("Reflex angle"); | ||
| }); | ||
| // Case 6: Invalid angles | ||
| test("should return 'Invalid angle' for invalid angles", () => { |
Contributor
There was a problem hiding this comment.
It may not be clear what values are consider "invalid angles".
Can you revise the test description to make it more informative?
Contributor
There was a problem hiding this comment.
Based on the test descriptions, it is unclear what value these function calls should return:
// It fits three of the test descriptions and they are giving contradicting info
isProperFraction(0, 0);
// No info about negative numbers
isProperFraction(-1, 2);
isProperFraction(1, -2);
isProperFraction(-1, -2);
isProperFraction(-2, 1);
isProperFraction(2, -1);
isProperFraction(-2, -1);
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have implement all the tasks according to the requirements, and test all the changes made.