London | 26-Jul-SDC | Roman Sanaye | Sprint 4 | Implement shell tool in Python

[RomanSanaye]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Implemented the wc shell tool using Python.

The implementation supports:

• Reading command-line arguments
• Separating flags and file paths
• Counting lines, words, and characters
• Supporting -l, -w, and -c flags
• Handling multiple files and displaying total counts

I tested the program against the required commands:

• wc sample-files/*
• wc -l sample-files/3.txt
• wc -w sample-files/3.txt
• wc -c sample-files/3.txt
• wc -l sample-files/*
• wc -w -l sample-files/3.txt
• wc -w -l sample-files/*

Questions

No questions.

Task ID: CYF-1152

[LonMcGregor]

Good start, but some things to fix.

also, Is the choice you have used for processing arguments the most effective? Is there a library you could use to help the implementation?

[LonMcGregor]

What do you think about the output code here? Can you spot any duplication across the file?

[RomanSanaye]

Thanks. I removed the duplicated output logic by creating a get_output() function.

[LonMcGregor]

If you run this with multiple files, how does the output look? What change could make it neater?

[RomanSanaye]

Thanks. I’ve updated the output formatting to make the results neater when using multiple files.

[RomanSanaye]

Good start, but some things to fix.

also, Is the choice you have used for processing arguments the most effective? Is there a library you could use to help the implementation?

Hi sir @LonMcGregor
Thanks for the feedback. I’ve changed the manual argument processing to use argparse.

[LonMcGregor]

These argparse implementations are better, and good idea in wc to write a function to handle printing output to reduce duplication.

I have some concern that you are not using the argparse library to best effect.

In particular, if we look at the cat implementation, you use this:

if args.n:
    flag = "-n"

followed later by

if flag == "-n":

Is storing things as strings even necessary when you are using a library to help you in this way?

Similar issues exist across the other implementations.