Fix IndexOutOfRangeException when an Enum's MetadataToken collides with Nullable<T> - #472
Open
VSteeph wants to merge 1 commit into
Open
Fix IndexOutOfRangeException when an Enum's MetadataToken collides with Nullable<T>#472VSteeph wants to merge 1 commit into
VSteeph wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
---Context
This PR comes from an issue we encountered. We started getting an IndexOutOfRangeException on a simple query that filters an entity based on its enum values:
result.Where(r => statuses.Contains(r.ProcessingInformation.ProcessingStatus));---Root Cause
TupleLayout.ValueFieldAccessorResolver.GetValue decides whether a type is Nullable by comparing the MetadataToken alone. The problem is that a MetadataToken is unique only within a single module, not globally. Our enum lives in an application assembly and happened to be assigned the same token as Nullable<> from CoreLib, so it was sent down the nullable branch. Once it reached TryResolveNullableEnum, which assumes the type is generic and calls GetGenericArguments()[0], the exception was thrown.
---Fix
Use of the module in addition to the MetadataToken in the condition, so the combination is unique.
---Performance
I understand the original comparison was an optimisation to save a few CPU operations. Je However, GetValue runs when the tuple layout is built and the descriptors should be cached, so this doesn't seem to be a hot path Nevertheless, here is a screenshot of a benchmark showing the differences:
Code used for the benchmark: