Skip to content

docs(example): drop the concurrent mode framing from the demo entry #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tyler-reitz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs(example): drop the concurrent mode framing from the demo entry #781

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7ab09a
docs(example): drop the concurrent mode framing from the demo entry
tyler-reitz Aug 5, 2026
8d54e0a
docs(example): note that the Suspense path does not run as checked in
tyler-reitz Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions example/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,16 @@ import * as React from 'react';
import * as ReactDOM from 'react-dom';

/**
* Use this instead of NonConcurrentModeApp to see a ReactFire demo with Suspense/Concurrent mode enabled
* This demo renders without Suspense. The Suspense version is the commented-out import
* below plus the render block at the bottom of this file.
*
* You'll need to use an experimental build of React to use Concurrent mode
* https://reactjs.org/docs/concurrent-mode-adoption.html#installation
* That path does not run as checked in: it needs react and react-dom on 18 or later, which
* this example is not yet on, and the `ReactDOM.render` call below has to be replaced
* rather than left alongside it. See #781 for the details.
*
* Suspense is off by default in ReactFire and is opted into with the `suspense` prop on
* `FirebaseAppProvider`. See the Suspense section of the README.
*/
// import {} from 'react/experimental' // make TS aware of experimental features
// import {} from 'react-dom/experimental' // make TS aware of experimental features
// import { App as ConcurrentModeApp } from './withSuspense/App';
import { App as NonConcurrentModeApp } from './withoutSuspense/App';
import './index.css';
Expand Down Expand Up @@ -37,7 +40,7 @@ ReactDOM.render(
);

/**
* FOR CONCURRENT MODE
* FOR THE SUSPENSE VERSION
*/
// ReactDOM.createRoot(rootElement).render(
// <FirebaseAppProvider firebaseConfig={firebaseConfig} suspense={true}>
Expand Down
Loading