Skip to content

Hotfix : 스크롤 UI 수정 #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GulSam00 merged 3 commits into from
Aug 14, 2026
Merged

Hotfix : 스크롤 UI 수정 #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
485701e
fix : 인기차트 곡 카드 번호 영역 밀림 수정 및 좌우 여백 추가 (#304)
GulSam00 Aug 14, 2026
f5c049f
refactor : 최신곡 페이지 본문 스크롤 ScrollArea로 통일 (#304)
GulSam00 Aug 14, 2026
ebfe0ac
Merge pull request #305 from GulSam00/fix/304-songCardScrollUi
GulSam00 Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions apps/web/src/app/popular/ChartRankingList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,10 @@ export default function ChartRankingList() {
</div>
) : (
items.map(item => (
<div key={item.id} className={cn('flex gap-4 border-b py-3 last:border-0')}>
<div
key={item.id}
className="flex items-start gap-4 border-b px-4 py-3 last:border-0"
>
<div
className={cn(
'flex h-8 w-8 shrink-0 items-center justify-center rounded-full',
Expand All @@ -161,7 +164,8 @@ export default function ChartRankingList() {
>
{item.rank}
</div>
<SongSummary song={item} />
{/* 순위 뱃지와 같은 행이라 min-w-0이 없으면 긴 곡 제목·가수가 번호 영역을 밀어낸다 */}
<SongSummary song={item} className="min-w-0 flex-1" />
</div>
))
)}
Expand Down
5 changes: 3 additions & 2 deletions apps/web/src/app/recent/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { useState } from 'react';
import CharacterMessage from '@/components/CharacterMessage';
import StaticLoading from '@/components/StaticLoading';
import { Button } from '@/components/ui/button';
import { ScrollArea } from '@/components/ui/scroll-area';
import {
Select,
SelectContent,
Expand Down Expand Up @@ -87,11 +88,11 @@ export default function RecentSongPage() {
</div>

{recentAddSongs && recentAddSongs.length > 0 ? (
<div className="flex min-h-0 flex-1 flex-col overflow-y-auto">
<ScrollArea className="min-h-0 flex-1">
{recentAddSongs.map(song => (
<RecentSongCard key={song.id} song={song} />
))}
</div>
</ScrollArea>
) : (
<CharacterMessage
variant="curious"
Expand Down
Loading