Add DNS-based Domain Control Validation support - #13
Closed
bhillkeyfactor wants to merge 1 commit into
Closed
Conversation
This reverts commit e65fa8a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds DNS-based Domain Control Validation (DCV) support, ported from the pattern used by HydrantID's separate
/domainsAPI resource.Domain,CreateDomainValidationPayload,Validatormodels + interfaces, andValidationMethod/DomainStatusEnumenumsHydrantIdClient:GetDomainListAsync,GetSubmitCreateDomainValidationAsync,GetSubmitCheckDomainValidationAsyncRequestManager:GetDomainsToValidate(CN + DNS SANs, deduped),GetCreateDomainValidationRequestEnroll()now checks domain validation status before submitting a CSR (New and Re-Issue paths), returningEndEntityStatus.EXTERNALVALIDATIONwith DNS record instructions when one or more domains are still pendingDeliberately deferred: delete/update-org domain endpoints,
GET /domains/validators(validator now comes from the matched policy'sDetails.Validator), and re-validation on plain renewals (renewals trust the prior validation).Note: this branch was briefly and accidentally pushed directly to
maindue to a local branch-tracking mixup; that commit was reverted onmainand the work moved to this branch for proper review.