-
Notifications
You must be signed in to change notification settings - Fork 60
Remove pre-push hooks #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+35
−26
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,29 +1,31 @@ | ||
| # Local quality gates. | ||
| # | ||
| # These hooks mirror the CI jobs so contributors catch failures before pushing. | ||
| # Keep commit-time work quick and limited to staged files. Broader validation | ||
| # remains available through the package scripts and CI rather than a push hook. | ||
| # | ||
| # The split matters: a pre-commit hook that runs the whole gate gets slow, people | ||
| # learn `--no-verify`, and the hook becomes decoration. Commit-time work is | ||
| # formatting only and touches staged files; the real gate runs once per push. | ||
| # | ||
| # Escape hatches: `git commit --no-verify`, or `LEFTHOOK=0 git push` to skip | ||
| # everything. Use them when you mean to, not by habit. | ||
| # Escape hatch: `git commit --no-verify`. Use it when you mean to, not by habit. | ||
|
|
||
| pre-commit: | ||
| parallel: true | ||
| parallel: false | ||
| jobs: | ||
| - name: format staged files | ||
| glob: "*.{ts,tsx,js,jsx,cjs,mjs,json,md,css,yml,yaml}" | ||
| run: npx prettier --write {staged_files} | ||
| glob: "*.{ts,tsx,js,jsx,cjs,mjs,json,md,css,yml,yaml,md}" | ||
| run: pnpm exec prettier --write "{staged_files}" | ||
| stage_fixed: true | ||
|
|
||
| pre-push: | ||
| parallel: false | ||
| jobs: | ||
| # The same commands as CI's format, lint, and typecheck jobs. | ||
| - name: verify | ||
| run: pnpm verify:push | ||
| - name: lint staged files | ||
| glob: "*.{ts,tsx,js,jsx,cjs,mjs}" | ||
| run: pnpm exec eslint "{staged_files}" | ||
|
|
||
| - name: typecheck staged files | ||
| glob: "*.{ts,tsx,cts,mts}" | ||
| run: | | ||
| filters=$( | ||
| git diff --cached --name-only --diff-filter=ACMRD | | ||
| sed -nE 's#^((apps|packages|tooling)/[^/]+)/.*#--filter=./\1#p' | | ||
| sort -u | ||
| ) | ||
|
|
||
| # CI runs this as its own job; keep the local push gate aligned with it. | ||
| - name: test | ||
| run: pnpm test | ||
| if [ -n "$filters" ]; then | ||
| pnpm exec turbo run typecheck $filters | ||
| fi | ||
|
alexanderpaolini marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.