Skip to content

Document the SameSite requirement for SAML reauthentication #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
labkey-bpatel wants to merge 1 commit into
base: release26.7-SNAPSHOT
Choose a base branch
from
Open

Document the SameSite requirement for SAML reauthentication #1472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions server/configs/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,19 @@ mail.smtpUser=@@smtpUser@@
# HTTP session timeout for users - defaults to 30 minutes
#server.servlet.session.timeout=30m

# SAML IdPs return authentication assertions via a cross-site POST. Without an explicit SameSite value,
# Chrome browser treats JSESSIONID as Lax and withholds it from that POST, except during a grace period covering
# cookies less than two minutes old. Reauthentication deliberately never replaces the session -- the
# signed-in session is what it verifies against -- so the cookie only ages, and any reauthentication more
# than a couple of minutes after sign-in arrives with no session cookie. That fails two ways: the request
# looks like a guest, producing a misleading "wrong user reauthenticated" error, and the response mints a
# guest session whose Set-Cookie overwrites the signed-in JSESSIONID, logging the user out. SameSite=None
# keeps the session attached to the callback and is only honored on Secure cookies,
# so this requires HTTPS.
#server.servlet.session.cookie.same-site=none
#server.servlet.session.cookie.secure=true
#server.servlet.session.cookie.http-only=true

## Turn on JSON-formatted HTTP access logging to stdout. See issue 48565
## https://tomcat.apache.org/tomcat-9.0-doc/config/valve.html#JSON_Access_Log_Valve
#jsonaccesslog.enabled=true
Expand Down