add OneDrive notes to episode2 and instructor notes - #302
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-shell/compare/md-outputs..md-outputs-PR-302 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2026-08-07 21:07:47 +0000 |
tobyhodges
left a comment
There was a problem hiding this comment.
Thanks @jmjamison. I've suggested one change, to add an internal link to the relevant part of the Instructor Notes page from your inline comment.
|
|
||
| :::: instructor | ||
|
|
||
| For notes about OneDrive, see instructor notes. |
There was a problem hiding this comment.
| For notes about OneDrive, see instructor notes. | |
| For notes about OneDrive, see [the Instructor Notes](instructors/instructor-notes.md#windows-onedrive-notes). |
Adding an internal link to make it easier for people to find this page.
There was a problem hiding this comment.
Perhaps surprisingly, the .md works here. The lesson infrastructure converts the filename into the correct relative path for the page produced from the source file at build time.
If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.
Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.
If any relevant discussions have taken place elsewhere, please provide links to these.
Details
For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.
Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.