fix: warn instead of raise in set_stratigraphic_column - #297
Open
manduinca wants to merge 1 commit into
Open
Conversation
set_stratigraphic_column raised DeprecationWarning unconditionally, which broke GeologicalModel.from_processor (its last step assigns the processor's column dict to the stratigraphic_column setter) and left the dict-to-column conversion code below the raise unreachable. Emit the deprecation warning with warnings.warn instead so the legacy dict format keeps working, and add a regression test covering from_processor. Fixes Loop3D#296
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #296
set_stratigraphic_columnraisedDeprecationWarningunconditionally, which brokeGeologicalModel.from_processor(its last step assigns the processor's column dict to thestratigraphic_columnsetter) and left the dict-to-column conversion code below the raise unreachable. This emits the deprecation warning withwarnings.warninstead, so the legacy dict format keeps working while still nudging users tostratigraphic_column.add_units.Added a regression test in
test_data_processor.pybuilding a small synthetic processor and assertingfrom_processorcompletes and populates the column. Verified the bundled geological map example path end to end (12 units + unconformity in the column) and the full test suite passes locally (709 passed).