Skip to content

Add iOS 27 scene lifecycle support #2492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
htenlik wants to merge 3 commits into
base: dev
Choose a base branch
from
+78 −7
Open

Add iOS 27 scene lifecycle support #2492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce0d873
Fix FavoriteFoodDetailView initialization order
htenlik Aug 12, 2026
0b43034
Add scene-based lifecycle support
htenlik Aug 12, 2026
58251be
Move app lifecycle handling to SceneDelegate
htenlik Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Loop.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,7 @@
89F9119424358E4500ECCAF3 /* CarbAbsorptionTime.swift in Sources */ = {isa = PBXBuildFile; fileRef = 89F9119324358E4500ECCAF3 /* CarbAbsorptionTime.swift */; };
89F9119624358E6900ECCAF3 /* BolusPickerValues.swift in Sources */ = {isa = PBXBuildFile; fileRef = 89F9119524358E6900ECCAF3 /* BolusPickerValues.swift */; };
89FE21AD24AC57E30033F501 /* Collection.swift in Sources */ = {isa = PBXBuildFile; fileRef = 89FE21AC24AC57E30033F501 /* Collection.swift */; };
A8C6D00D302CDFE200D4360D /* SceneDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = A8C6D00C302CDFE200D4360D /* SceneDelegate.swift */; };
A90EF53C25DEF06200F32D61 /* PluginManager.swift in Sources */ = {isa = PBXBuildFile; fileRef = C16DA84122E8E112008624C2 /* PluginManager.swift */; };
A90EF54425DEF0A000F32D61 /* OSLog.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4374B5EE209D84BE00D17AA8 /* OSLog.swift */; };
A91D2A3F26CF0FF80023B075 /* IconTitleSubtitleTableViewCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = A91D2A3E26CF0FF80023B075 /* IconTitleSubtitleTableViewCell.swift */; };
Expand Down Expand Up @@ -1128,6 +1129,7 @@
89F9119324358E4500ECCAF3 /* CarbAbsorptionTime.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CarbAbsorptionTime.swift; sourceTree = "<group>"; };
89F9119524358E6900ECCAF3 /* BolusPickerValues.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BolusPickerValues.swift; sourceTree = "<group>"; };
89FE21AC24AC57E30033F501 /* Collection.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Collection.swift; sourceTree = "<group>"; };
A8C6D00C302CDFE200D4360D /* SceneDelegate.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SceneDelegate.swift; sourceTree = "<group>"; };
A900531A28D60862000BC15B /* Loop.shortcut */ = {isa = PBXFileReference; lastKnownFileType = file; path = Loop.shortcut; sourceTree = "<group>"; };
A900531B28D608CA000BC15B /* Cancel Override.shortcut */ = {isa = PBXFileReference; lastKnownFileType = file; path = "Cancel Override.shortcut"; sourceTree = "<group>"; };
A900531C28D6090D000BC15B /* Loop Remote Overrides.shortcut */ = {isa = PBXFileReference; lastKnownFileType = file; path = "Loop Remote Overrides.shortcut"; sourceTree = "<group>"; };
Expand Down Expand Up @@ -1726,6 +1728,7 @@
43776F8E1B8022E90074EA36 /* Loop */ = {
isa = PBXGroup;
children = (
A8C6D00C302CDFE200D4360D /* SceneDelegate.swift */,
C16DA84022E8E104008624C2 /* Plugins */,
B66D1F322E6A5D6600471149 /* Localizable.xcstrings */,
B66D1F382E6A5D6600471149 /* InfoPlist.xcstrings */,
Expand Down Expand Up @@ -3477,6 +3480,7 @@
4389916B1E91B689000EEF90 /* ChartSettings+Loop.swift in Sources */,
C178249A1E1999FA00D9D25C /* CaseCountable.swift in Sources */,
B4F3D25124AF890C0095CE44 /* BluetoothStateManager.swift in Sources */,
A8C6D00D302CDFE200D4360D /* SceneDelegate.swift in Sources */,
1DDE273D24AEA4B000796622 /* SettingsViewModel.swift in Sources */,
DD3DBD292A33AFE9000F8B5B /* IntegralRetrospectiveCorrectionSelectionView.swift in Sources */,
A9347F3124E7521800C99C34 /* CarbBackfillRequestUserInfo.swift in Sources */,
Expand Down
9 changes: 3 additions & 6 deletions Loop/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import LoopKit
final class AppDelegate: UIResponder, UIApplicationDelegate, WindowProvider {
var window: UIWindow?

private let loopAppManager = LoopAppManager()
let loopAppManager = LoopAppManager()
private let log = DiagnosticLog(category: "AppDelegate")

// MARK: - UIApplicationDelegate - Initialization
Expand All @@ -24,17 +24,14 @@ final class AppDelegate: UIResponder, UIApplicationDelegate, WindowProvider {

log.default("lastPathComponent = %{public}@", String(describing: Bundle.main.appStoreReceiptURL?.lastPathComponent))

loopAppManager.initialize(windowProvider: self, launchOptions: launchOptions)
loopAppManager.launch()
return loopAppManager.isLaunchComplete
// SceneDelegate handles LoopAppManager initialization and launch.
return true
}

// MARK: - UIApplicationDelegate - Life Cycle

func applicationDidBecomeActive(_ application: UIApplication) {
log.default(#function)

loopAppManager.didBecomeActive()
}

func applicationWillResignActive(_ application: UIApplication) {
Expand Down
19 changes: 19 additions & 0 deletions Loop/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,25 @@
<string>NewCarbEntryIntent</string>
<string>ViewLoopStatus</string>
</array>
<key>UIApplicationSceneManifest</key>
<dict>
<key>UIApplicationSupportsMultipleScenes</key>
<false/>
<key>UISceneConfigurations</key>
<dict>
<key>UIWindowSceneSessionRoleApplication</key>
<array>
<dict>
<key>UISceneConfigurationName</key>
<string>Default Configuration</string>
<key>UISceneDelegateClassName</key>
<string>$(PRODUCT_MODULE_NAME).SceneDelegate</string>
<key>UISceneStoryboardFile</key>
<string>Main</string>
</dict>
</array>
</dict>
</dict>
<key>UIBackgroundModes</key>
<array>
<string>bluetooth-central</string>
Expand Down
51 changes: 51 additions & 0 deletions Loop/SceneDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
//
// SceneDelegate.swift
// Loop
//
// Scene-based lifecycle support for iOS 27.
//

import UIKit

final class SceneDelegate: UIResponder, UIWindowSceneDelegate, WindowProvider {

var window: UIWindow?

private var loopAppManager: LoopAppManager {
(UIApplication.shared.delegate as! AppDelegate).loopAppManager
}

func scene(
_ scene: UIScene,
willConnectTo session: UISceneSession,
options connectionOptions: UIScene.ConnectionOptions
) {
guard let windowScene = scene as? UIWindowScene else {
return
}

let storyboard = UIStoryboard(name: "Main", bundle: nil)

guard let rootViewController = storyboard.instantiateInitialViewController() else {
return
}

let window = UIWindow(windowScene: windowScene)
window.rootViewController = rootViewController

self.window = window

window.makeKeyAndVisible()

loopAppManager.initialize(
windowProvider: self,
launchOptions: nil
)

loopAppManager.launch()
}

func sceneDidBecomeActive(_ scene: UIScene) {
loopAppManager.didBecomeActive()
}
}
2 changes: 1 addition & 1 deletion Loop/Views/FavoriteFoodDetailView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ public struct FavoriteFoodDetailView: View {
public init(food: StoredFavoriteFood?, onFoodDelete: @escaping (StoredFavoriteFood) -> Void, isConfirmingDelete: Bool = false, carbFormatter: QuantityFormatter, absorptionTimeFormatter: DateComponentsFormatter, preferredCarbUnit: HKUnit = HKUnit.gram()) {
self.food = food
self.onFoodDelete = onFoodDelete
self.isConfirmingDelete = isConfirmingDelete
self.carbFormatter = carbFormatter
self.absorptionTimeFormatter = absorptionTimeFormatter
self.preferredCarbUnit = preferredCarbUnit
self.isConfirmingDelete = isConfirmingDelete
}

public var body: some View {
Expand Down