[WIP] Plugin Picker Sheet

[Camji55]

⚠️ Do Not Merge, This is simply a tracking PR
Replaces the current popover for selecting a plugin with a custom sheet.

Core

• Plugin Picker Sheet LoopKit#604
• Plugin Picker Sheet Loop#2490

CGM

• Add Device Manufacturer Field dexcom-share-client-swift#54
• Add Device Manufacturer Field EversenseKit#1
• Add Device Manufacturer Field CGMBLEKit#216
• Add Device Manufacturer Field G7SensorKit#61
• Add Device Manufacturer Field LibreLoop#9
• Add Device Manufacturer Field LibreTransmitter#41
• Add Device Manufacturer Field NightscoutRemoteCGM#34

Pump

• Add Device Manufacturer Field MedtrumKit#1
• Add Device Manufacturer Field MinimedKit#35
• Add Device Manufacturer Field loopandlearn/OmnipodKit#130

Service

• Add Device Manufacturer Field AmplitudeService#31
• Add Device Manufacturer Field LogglyService#28
• Add Device Manufacturer Field MixpanelService#7
• Add Device Manufacturer Field NightscoutService#28
• Add Device Manufacturer Field TidepoolService#37

[itsmojo]

The Insulet description for Add Pump item looks out of place. It lists all various pod (pump) types while the Minimed does not even though only a small submit of the various Minimed/Medtronic insulin pumps are supported. To better fit in with the other choices here the current "All Omnipod Types" or just "Omnipod" would seem more appropriate. especially since we now handle every pod type that Insulet has shipped over the past 15 years.

But if we must inconsistently list all the supported pod (pump) types for just the Insulet pump type (my vote on this is a strong no), "Eros" should be replaced by "Classic" since Insulet refers to this pod type as "Omnipod Classic (Gen 3)" or "Omnipod Classic" and it never uses its internal code name of "Eros" for this pod type in any of their literature. This could be because the word eros comes from ancient Greek and means sexual love and physical desire and serves as the root of the English word erotic.

[Camji55]

@itsmojo That's an Interesting fact on the "Eros" naming, thanks for sharing!

All Omnipod Types felt a little out of place in the context of CGM plugins using the / separator (see FreeStyle Libre 1 / 2 / 2+, Eversense E3 / E365, and the Dexcom G6 / ONE/Dexcom G7 / ONE+). I think Omnipod could be okay if we don't want to be explicit.

That said, I'd argue being explicit about supported devices is easier to maintain long-term. If Insulet ships an Omnipod 6, both All Omnipod Types and Omnipod would imply support for it, so we'd have to update the title anyway. By the same logic, it probably makes sense to be explicit with MiniMed too — as it stands, it's not clear that something like the MiniMed Flex isn't currently supported.

A benefit to using a custom view like this is that we can add always add a description field if it would make more sense to list device compatibility within the plugin there.

[itsmojo]

The reason why the All Omnipod Types name was used for the OmnipodKit pump manager name was because it had to co-exist for an extended period along with OmniKit which already used the pump manager name of "Omnipod". The All Omnipod Types label also works for the transition from having no O5 support, to O5 being available in certain situations, to the upcoming full O5 support (when reasonably understood as "All Supported Omnipod Types").

I agree that the All Omnipod Types pump [manager] name feels a bit off from the other pump [manager] names, especially now that the OmniKit and the OmniBLE pump managers are no longer being included. I'd rather just use "Omnipod" for the OmnipodKit pump [manager] label going forward (especially when properly interpreted as "for supported pod types"). But if the MiniMed pump [manager] is now going to be displayed as "MiniMed x15 / x22 / x23 / x54" as in the current mock up, going with "Omnipod Classic / DASH / 5" would also be acceptable. The eventual problem we might have is that always including the various supported variants for each pump or CGM [manager] in its name might one day get too lengthly.