fix: restore get_env() template function - #577
Merged
Merged
Conversation
tera 2 dropped the built-in get_env(), so floki.yaml files using it stopped rendering as of 2.4.4. Reimplement and register it, with tests so a future tera bump can't silently drop it again. Fixes #576 Signed-off-by: Max Dymond <max.dymond@alianza.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #576.
tera 2 dropped the built-in
get_env(), sofloki.yamlfiles using it stopped rendering as of floki 2.4.4:The fix
Reimplement
get_envas a custom tera function and register it alongside the existingyaml/json/tomlloaders. Same signature as tera 1:get_env(name="HOME"), with an optionaldefaultused when the variable is unset, and an error otherwise.CI coverage
Three unit tests in
src/config.rscover the set, defaulted, and missing-and-no-default cases.cargo testalready runs on every PR, so a future tera bump that dropsget_envagain fails the build rather than shipping.Docs updated to mention
get_envalongside the existingenv.*example.