fix(e2e): separate Podman Machine loopback listeners - #2622
fix(e2e): separate Podman Machine loopback listeners#2622matthewgrossman wants to merge 2 commits into
Conversation
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
|
🌿 Preview your docs: https://nvidia-preview-pr-2622.docs.buildwithfern.com/openshell |
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
matthewgrossman
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
Validation: PR #2622 is project-valid because it is a maintainer-authored, concentrated fix for validated issue #2607 covering macOS Podman Machine gateway loopback behavior, with matching driver-guide and debugging-skill updates.
Head SHA: eb77ee64c2ebc5df36e1726b4a096f563260025a
Base SHA: 85d992f768bf2152fc5b815fc4031c61eae1ac52
Merge base SHA: f383ee1038f91921e104405cd01e4150d533fdbe
Patch ID: bdb936589103f37cbb7d356b0f62788ea662bd19
Gator payload: 2
Review mode: initial
Previous reviewed SHA: none
Blocking findings:
- No blocking findings remain.
Carried findings:
- None
Non-blocking suggestions:
- None
Docs: Updated in docs/reference/sandbox-compute-drivers.mdx; no navigation change needed because the existing Reference folder already includes this page.
E2E: Applied test:e2e because the change affects Podman gateway listener/callback behavior and the Podman e2e harness.
Next state: gator:watch-pipeline
|
Label |
Summary
TL;DR: Running
mise run e2e:podmanon macOS previously failed because Podman Machine routed its internal host callback to the same address and port as the main OpenShell gateway listener. The harness now gives the main gateway and Podman callbacks distinct loopback addresses, so the command can spin up the gateway and run the Podman E2E suite successfully on macOS.Related Issue
Fixes #2607
Changes
[::1]:PORT; keep native Linux on127.0.0.1:PORT.https://localhost:PORT, relying on standard macOS IPv6-first localhost resolution while preserving a valid TLS DNS name.::1.127.0.0.1:PORTwith its restricted authorization scope; do not broaden either listener to0.0.0.0.debug-openshell-clusterguidance.Testing
mise run pre-commitpassesmise run testpassescargo test -p openshell-core resolve_ssh_gatewaypassesmise run e2e:podmanpasses on macOS Podman MachineChecklist