Fix spectre buffs only applying from the selected spectre - #10225
Open
canuysal wants to merge 1 commit into
Open
Fix spectre buffs only applying from the selected spectre#10225canuysal wants to merge 1 commit into
canuysal wants to merge 1 commit into
Conversation
Raise Spectre now instantiates every spectre in the spectre list so their buff, aura and curse skills are applied, instead of only the ones from the spectre currently selected on the skill. The selected spectre is still the only one used for minion DPS and defence calculations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise Spectre now instantiates every spectre in the spectre list so their buff, aura and curse skills are applied, instead of only the ones from the spectre currently selected on the skill. The selected spectre is still the only one used for minion DPS and defence calculations.
Fixes #9308.
Description of the problem being solved:
When Raise Spectre is enabled, only the spectre currently selected on the skill (defaulting to the first one in the Manage Spectres list) had its buff, aura and curse skills applied. For example, with Perfect Blood Demon, Perfect Forest Tiger and Perfect Guardian Turtle in the list, the Tiger's Haste and the Turtle's Determination were never applied unless that specific spectre was selected as the active minion. The only workaround was socketing one Raise Spectre gem per spectre.
Raise Spectre now instantiates every spectre in the spectre list so their buff, aura and curse skills are applied, instead of only the ones from the spectre currently selected on the skill. The selected spectre is still the only one used for minion DPS and defence calculations. Corpse-granted mods (ally/player/minion modifiers and the beast spectre condition) are also now applied from every spectre in the list rather than just the selected one.
This is based on the approach from the unmerged
add_spectre-skill-buffsbranch by @LocalIdentity (26cb0d1), rebased and adapted to the current dev codebase, withskillTypes/minionSkillTypesadditionally carried into the temporary skill copy so support compatibility checks behave the same as for the main minion.Steps taken to verify a working solution:
spec/System/TestSpectreBuffs_spec.lua) reproducing the exact scenario above; it fails on current dev (Haste/Determination missing) and passes with this changeLink to a build that showcases this PR:
Add perfect forest tiger - perfect blood demon, and perfect guardian turtle. Buffs should also affect players (turtle)
https://pobb.in/_S9pWnHIblbX
Before screenshot:
After screenshot: