Improve calc performance - #10228
Open
vaisest wants to merge 3 commits into
Open
Conversation
vaisest
marked this pull request as ready for review
August 15, 2026 15:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This improves raw calc performance (measured with a luajit script just running power report repeatedly) by around 20%. This is probably not going to result in the actual in-program report being 20% faster, but it's an improvement nonetheless
This is done by:
These were mostly done with LLM ideas and profiling, and a separate script running power reports on a spark build. I think there is certainly more room for improvement here, but it pretty quickly turns into adding more code, which isn't good for readability, and the gains aren't that amazing.
The class related code probably still sucks. There could be more room for improvement, and it might be noticeable, because the calc code creates a ton of mod lists using new()
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: