RELEASE.md: promote dependency-override check to a pre-release gate - #12
Merged
jnasbyupgrade merged 1 commit intoAug 11, 2026
Conversation
extension_tools#45 highlighted that this rule (never release while CI builds a dependency from a git ref instead of its published PGXN version) was only documented as a passive "notes/gotchas" aside, not an actual step in the pre-release checklist -- easy to skip since nothing forces you to read that far. Move the real explanation into step 2's checklist and leave a pointer behind in its place.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RELEASE.mdinto an actual checklist item in step 2 ("Pre-release checks").Why
Postgres-Extensions/extension_tools#45 is trimming that repo's local
RELEASE.mddown to just itsCAT_TOOLS_GIT_REFguardrail, on the assumption the shared doc covers the general case — it does, but only as a footnote nobody is forced to read before cutting a release. The actual risk isn't specific to any one pinned version (e.g.cat_tools0.3.0): it's that CI testing against a git-ref dependency override is, by construction, not testing the normal PGXN-install path a real consumer would use. Releasing while that override is live ships a zip whose declared dependency floor nothing on PGXN can actually satisfy. Making this a checklist step instead of a gotcha closes that gap.