Skip to content

Revert CAT_TOOLS_GIT_REF override now that cat_tools 0.3.0 is on PGXN - #47

Open
jnasbyupgrade wants to merge 1 commit into
Postgres-Extensions:masterfrom
jnasbyupgrade:revert-cat-tools-git-ref
Open

Revert CAT_TOOLS_GIT_REF override now that cat_tools 0.3.0 is on PGXN#47
jnasbyupgrade wants to merge 1 commit into
Postgres-Extensions:masterfrom
jnasbyupgrade:revert-cat-tools-git-ref

Conversation

@jnasbyupgrade

Copy link
Copy Markdown
Contributor

Summary

  • cat_tools 0.3.0 was published to PGXN on 2026-08-06, so a plain pgxn install
    now satisfies META.in.json's declared cat_tools: 0.3.0 floor. The
    workflow-level CAT_TOOLS_GIT_REF: 0.3.0 override (added to work around
    PGXN's previously-stale 2017 cat_tools release) is no longer needed.
  • This is the release-blocking condition both this repo's (now-removed)
    RELEASE.md and the shared ../ai/RELEASE.md warn about: never cut a
    release while a dependency is pinned to a git ref instead of PGXN. Clearing
    it is a prerequisite for cutting the pending 1.0.0 release.
  • pg-tle-test still needs a concrete git ref for its own from-scratch
    cat_tools clone (that job registers cat_tools via pg_tle, never through
    PGXN/filesystem install), so it now carries its own job-level
    CAT_TOOLS_GIT_REF: 0.3.0, decoupled from the removed top-level override.
  • Deleted the local RELEASE.md: its only remaining content was documenting
    this one instance of the override, which this PR resolves. The generic
    guardrail is already covered by the shared Postgres-Extensions/ai/RELEASE.md
    (linked from the file being removed) — per that doc's own guidance, a repo
    with no other repo-specific deviation doesn't need a local copy.

Verified locally

  • Removing the override, a plain pgxn install 'cat_tools>=0.2.1' --sudo
    fetches and installs cat_tools 0.3.0 from PGXN (confirmed by running it).
  • make verify-results passes on PG17 (fresh install + build tests).
  • .github/workflows/ci.yml parses as valid YAML after the edit.

Test plan

  • CI green on this PR (fresh-install matrix, pg_tle job, pg_upgrade job) —
    confirms the plain-PGXN path works in the actual CI container, not just
    locally.

cat_tools 0.3.0 published to PGXN 2026-08-06, so a plain `pgxn install`
now satisfies META.in.json's declared floor -- the git-source override
this repo's (now-deleted) RELEASE.md warned never to release with is no
longer needed. Unblocks cutting the 1.0.0 release per ../ai/RELEASE.md.

pg-tle-test still needs a concrete git ref for its own from-scratch
cat_tools clone (that job never installs via PGXN), so it gets its own
job-level CAT_TOOLS_GIT_REF, decoupled from the removed release gate.
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ac22f570-a611-4a26-bd53-d31e6594fb10

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown

Claude finished @jnasbyupgrade's task in 1m 6s —— View job


Code Review

Tasks:

  • Read trigger request and repo CLAUDE.md
  • Review diff (.github/workflows/ci.yml, RELEASE.md removal)
  • Check reasoning against ../ai/RELEASE.md guardrail
  • Verify pg-tle-test job-level override is correctly scoped
  • Post review feedback

Summary

This is exactly the release-blocking cleanup the PR description says it is, and the diff backs it up:

  • META.in.json:82 declares "cat_tools": "0.3.0" as the floor, and Makefile:104 installs via pgxn install 'cat_tools>=0.2.1' --sudo — with 0.3.0 now on PGXN, that plain install satisfies the declared floor without the workflow-level override.
  • Removing the top-level CAT_TOOLS_GIT_REF: 0.3.0 env (.github/workflows/ci.yml:17-26 in the old version) correctly un-blocks the release per the guardrail the (now-deleted) RELEASE.md described.
  • The pg-tle-test job's new job-level CAT_TOOLS_GIT_REF: 0.3.0 (ci.yml:311) is correctly scoped — that job clones cat_tools from git directly for pg_tle registration (never through PGXN/filesystem install), so it never picked up the Makefile's pgxn install path and genuinely needs its own explicit ref. Decoupling it from the top-level override is the right call.
  • The removed CAT_TOOLS_GIT_REF=$(make -s print-CAT_TOOLS_GIT_REF ...) shell dance is replaced with the value already being in the job's env — simpler and correct, since the job-level env: is visible to the run: step.
  • Deleting RELEASE.md is reasonable: its only content was documenting this one override, which this PR resolves, and the generic guardrail already lives in the shared ../ai/RELEASE.md. Confirmed no other file in the repo links to the deleted RELEASE.md.
  • CI on this PR is green (fresh-install matrix, pg_tle job, pg_upgrade job all passed), which is the load-bearing verification for a change like this.

No issues found. Nothing to flag, no suggested fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant