Add RELEASE.md: pgxntool here creates branch, not tag - #1
Draft
jnasbyupgrade wants to merge 1 commit into
Draft
Conversation
This repo's vendored pgxntool predates git-tag-based releases: `make tag` literally runs `git branch $(PGXNVERSION)` + push, not `git tag`. The shared ../ai/RELEASE.md process (from Postgres-Extensions/ai#8) explicitly anticipates this as a possible gotcha but assumes tags by default, so it would be actively misleading here without this note. Verified 0.1, 0.1.0, 0.1.1, 0.2.0 are real historical release branches (ancestors of master), not stale forks, and that git tag -l is empty.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RELEASE.mddocumenting one genuine, repo-specific deviation from the org's new shared release process doc (Add shared RELEASE.md for PGXN-extension repos ai#8, not yet merged): this repo's vendoredpgxntoolpredates git-tag-based releases, somake tag/make distcreate and push a git branch named after the version, not a git tag.Why this is real, not stale docs
pgxntool/base.mk'stagtarget here is:git tag -lin this repo is empty. Instead there are branches0.1,0.1.0,0.1.1,0.2.0— verified to each be an ancestor ofmaster(real historical release points produced bymake tag, not stale forks or abandoned work).pgxntool/README.ascin this repo's vendored copy also still says "make tagwill create a git branch," consistent with the code.The shared
../ai/RELEASE.mddoc actually anticipates this exact situation in its gotchas section ("check the vendored version's actual behavior if a repo's docs still say 'branch'") — but assumes tags by default everywhere else (safety-check step, tag/dist step, idempotency behavior). Without a local note, following it here verbatim would be misleading in a few concrete ways spelled out in the new file (comparing against "the tag" when there is none, and different idempotency:git brancherrors on re-creation even when it would point at the same commit, unlike a tag).Dependency
This PR references
../ai/RELEASE.md, which is not yet merged — see Postgres-Extensions/ai#8. Marking this draft until that lands; the content here stands on its own either way, but the link target won't resolve until then.Test plan
git tag -lis empty and0.1/0.1.0/0.1.1/0.2.0are branches, each an ancestor ofmaster(git merge-base --is-ancestor <branch> master).pgxntool/base.mk'stag/dist/rmtag/forcetagtargets operate on branches (git branch, notgit tag).pgxntool/README.asc(vendored copy) still documents "branch" behavior.