Add repo-specific RELEASE.md (tag is a branch here, not a tag) - #1
Draft
jnasbyupgrade wants to merge 1 commit into
Draft
Add repo-specific RELEASE.md (tag is a branch here, not a tag)#1jnasbyupgrade wants to merge 1 commit into
jnasbyupgrade wants to merge 1 commit into
Conversation
…results This repo vendors a much older, subtree-vendored pgxntool whose make tag creates a git branch (not a tag) and predates the stable pseudo-version and verify-results mechanisms the org's shared ../ai/RELEASE.md assumes. Following that doc verbatim here would be actively wrong, so document the concrete deviations locally and point to the shared doc for everything else.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Investigated whether trunklet needs a local
RELEASE.mdnow that the orghas a shared one (Postgres-Extensions/ai#8, not yet merged). It does, for
genuine repo-specific reasons — this repo's actual release mechanics
diverge from the shared doc in ways that would produce wrong results if
followed verbatim:
make tagcreates a git branch, not a tag. This repo's vendoredpgxntool/base.mk(squashed in viagit subtree, not the submoduleother repos use — a much older vintage) implements
tag:asgit branch $(PGXNVERSION); git push --set-upstream origin $(PGXNVERSION).Verified:
git tag -landgit ls-remote --tagsare both empty, whileevery past release (
0.0.1..0.3.3) exists as a branch onorigin.The shared doc's own "Notes / gotchas" section already anticipates this
exact situation ("older
pgxntool/README.ascwording describing theresult as a 'branch'") — trunklet's vendored
README.ascstill saysthis, and unlike some repos it's not just stale wording, the Makefile
genuinely still does it.
stablepseudo-version.default_version/META.in.jsonversionare always a real released number (currently
0.3.3), never the literalstring
stable— this vintage predates that mechanism entirely.verify-resultstarget. Onlyresults(regenerate expectedoutput) and
installcheck(marked.IGNORE) exist, so a greenmake testdoesn't provepg_regresspassed.This PR adds a minimal
RELEASE.mddocumenting only these three concretedeviations and pointing to
../ai/RELEASE.mdfor everything else.Depends on Postgres-Extensions/ai#8 landing first for the linked doc to
resolve (
https://github.com/Postgres-Extensions/ai/pull/8).Test plan
git tag -l/git ls-remote --tags upstreamare empty andall nine version branches (
0.0.1..0.3.3) plusvariantareancestors of
master(confirming they're historical branch-based"tags", not divergent release lines).
masterHEAD == branch0.3.3HEAD exactly (same SHA).pgxntool/base.mk'stag/rmtag/disttargets andpgxntool/README.asc's description oftag.stableversion anywhere intrunklet.control/META.in.json, and noverify-resultstarget inbase.mk.