Show public wallet addresses for protected wallets and add checkphrases - #135
Merged
Conversation
- Revert the #126 display change that replaced addresses of password-protected wallets with "[Encrypted]" in wallet list/view. The envelope address is public information and is validated as canonical Quantus SS58 at load; envelope tampering is still caught by the Integrity check on unlock, and passwordless send-path resolution still refuses to trust the envelope. - Show a human-readable checkphrase (qp-human-checkphrase, same algorithm and wordlist as the mobile app) under every wallet address in create/import/from-seed/list/view/delete.
illuzen
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
quantus wallet list/view/deleteshow the wallet address again for password-protected wallets, instead of[Encrypted].Checkphrase: Piano-Mature-Drop-Vibrant-Snack.Why
#126 stopped displaying the envelope address for password-protected wallets because it is not authenticated by decryption. But the wallet address is public information, not security critical, and hiding it made
wallet listuseless for protected wallets. This restores the pre-#126 display behavior while keeping the #126 protections that matter:find_wallet_address) still refuses to trust the envelope for protected wallets.Checkphrase
Uses the published
qp-human-checkphrasecrate (same algorithm as the mobile app). The 2048-word list is vendored viainclude_str!because the crate only loads it from the current working directory at runtime; the file is byte-identical to the mobile app asset.Placeholder values like
[Wrong password]never get a checkphrase.Testing
cargo test --lib wallet::(70 tests, includes updated tampered-envelope and list/view tests, plus new checkphrase tests)cargo +nightly fmtand clippy clean.