fix(routes/index): scale down the adapter graph on small screens - #1108
Draft
sukvvon wants to merge 1 commit into
Draft
fix(routes/index): scale down the adapter graph on small screens#1108sukvvon wants to merge 1 commit into
sukvvon wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 6bdbdef | Commit Preview URL Branch Preview URL |
Aug 04 2026, 12:49 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Framework Agnostic diagram on the landing page overflows its card on phones — the React and Solid nodes sit flush against the edges and read as clipped.
Cause
The node coordinates are hard-coded against a 320×128 grid, so the whole graph is scaled as a unit.
scale-[1.35]exists to fill the 460px slot that only appears atlg(PrinciplePanelisw-full lg:w-[460px]), but the scale applied at every width.At 375px the graph renders 432px wide inside a 311px slot — 121px of overflow.
Fix
Three steps instead of one fixed scale:
Measured
Desktop rendering is byte-for-byte unchanged; only widths below
smare affected.Why the middle step
The graph steps in discrete sizes while the slot grows continuously, so one value cannot serve both ends. Holding
scale-90up tosmleaves 244px of slack at 596px — more empty space than diagram.min-[520px]splits the difference.Known gaps
Draft while the continuous-scaling alternative is evaluated.