Fix network name detection for multi-SIM devices - #74
Open
CodeName-Anti wants to merge 1 commit into
Open
Conversation
…network operator name
There was a problem hiding this comment.
Pull request overview
This PR updates DeviceStateManager’s cellular network name detection to better support multi‑SIM devices by retrieving the operator name from the currently active data subscription rather than relying on the default TelephonyManager instance.
Changes:
- Use
SubscriptionManagerto resolve the active/default data subscription ID. - Use a subscription-scoped
TelephonyManager(createForSubscriptionId) to fetchnetworkOperatorNamefor the active data SIM.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+367
to
+377
| val dataSubId = | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) { | ||
| SubscriptionManager.getActiveDataSubscriptionId() | ||
| } else { | ||
| @Suppress("DEPRECATION") | ||
| SubscriptionManager.getDefaultDataSubscriptionId() | ||
| } | ||
|
|
||
| val dataSimTelephonyManager = | ||
| telephonyManager?.createForSubscriptionId(dataSubId) | ||
| val operatorName = dataSimTelephonyManager?.networkOperatorName |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes network name detection on multi-SIM devices by using the currently active data SIM instead of defaulting to the first available SIM.