Validate CSVFormat invariants when deserializing - #632
Merged
garydgregory merged 1 commit intoAug 13, 2026
Conversation
garydgregory
added a commit
that referenced
this pull request
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSVFormat.readObjectrestores the fields and reinitializes the transientwriteLock, but it never callsvalidate(), so deserialization is the one path that builds aCSVFormatwithout the invariant checks the constructor runs. A crafted stream can therefore carry a state theBuilderrefuses, such as the quote character equal to the delimiter,QuoteMode.NONEwith no escape character, or duplicate headers. I hit this while auditing theSerializablesurface against the constructor'svalidate().Call
validate()inreadObjectonce the fields are restored and rethrow itsIllegalArgumentExceptionasInvalidObjectException, so a hostile stream is rejected at read time instead of surviving as a broken format that later misparses input or throws from deep inside a print/parse callee.readObjectis the only place that guards the deserialization path, since theBuilderand constructor never see it.mvn; that'smvnon the command line by itself.