Skip to content

Improving error messages when an annotation processor crashes. - #9560

Draft
lahodaj wants to merge 2 commits into
apache:masterfrom
lahodaj:improve-ap-error-messages
Draft

Improving error messages when an annotation processor crashes.#9560
lahodaj wants to merge 2 commits into
apache:masterfrom
lahodaj:improve-ap-error-messages

Conversation

@lahodaj

@lahodaj lahodaj commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Suggested by @mbien .


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

LLMs, Commit messages and PR description:

  • Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.
  • LLM assisted commits should be attributed with an Assisted-by: MODEL_NAME MODEL_VERSION line appended to the commit message.
    • Please mention coding assistance in the PR description too (eg. by adding the same Assisted-by line from above)
    • Please describe the changes in your own words - we'd like to know you understand the changes being made!

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@lahodaj lahodaj added this to the NB32 milestone Aug 13, 2026
@lahodaj
lahodaj requested review from dbalek and mbien August 13, 2026 11:53
@lahodaj lahodaj added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Aug 13, 2026
@lahodaj
lahodaj force-pushed the improve-ap-error-messages branch from 1f12e3c to 86f0b8a Compare August 13, 2026 12:14
@mbien

mbien commented Aug 13, 2026

Copy link
Copy Markdown
Member

thanks for looking into this. The key puzzle piece was the fact that printMessage() wouldn't display in UI when no element was passed as parameter. Given that it was already used that way (but it didn't work?), I assumed It must be me looking at the wrong place.

I made some changes on top of this PR:

  • switch back to generic (but improved) AP message: even though the changes here are mainly due to lombok, lets try to make the improvements useful for all APs
  • use SourceVersion.latest().runtimeVersion().feature() instead of constant as msg parameter
  • use printStackTrace(writer) to format exception to make it look "native"
  • add jar location, AP name and javac version to exception message
  • clear class cache on AP failure

commit would be at https://github.com/mbien/netbeans/tree/improve-ap-error-messages, let me know what you think.

screenshot:
ap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants