feat(eip8130): re-pin Keystore contract set to finalized deployment - #4322
feat(eip8130): re-pin Keystore contract set to finalized deployment#4322chunter-cb wants to merge 1 commit into
Conversation
The reference contracts (base/eip-8130) finalized under a mined, non-zero CREATE2 salt shared across the whole set (yielding the Keystore's 0x8130… vanity address). Re-pin every address, the shared salt, and the four changed init-code hashes; the high-rate-payer proxy code hash is updated to match the new implementation. P256/WebAuthn/AlwaysValid init-code hashes are unchanged — only their addresses moved with the salt. Verified against the base/eip-8130 Deploy.s.sol broadcast (chain 84532): each address CREATE2-derives from factory + shared salt + init-code hash (addresses_match_create2_derivation stays green).
Review SummaryThe diff is a straightforward re-pin of EIP-8130 system-contract constants (salt, addresses, init-code hashes) to match a finalized deployment. The existing FindingStale test doc comment (
This should say "shared mined salt" (or similar) since this PR changes |
Summary
Re-pin the EIP-8130 system-contract set in
addresses.rsto the finalizedbase/eip-8130deployment (contract renamedAccountConfiguration→Keystore).0x8130…vanity address). UpdatesSALT(wasB256::ZERO), all seven addresses, and the four changed init-code hashes.P256/WebAuthn/AlwaysValidinit-code hashes are unchanged — only their addresses moved with the salt.Verified against the
base/eip-8130Deploy.s.solbroadcast (chain 84532): each address CREATE2-derives from factory + shared salt + init-code hash.Test plan
cargo test -p base-common-consensus --lib addresses::(incl.addresses_match_create2_derivation) passes