sync: header and binding mirrors for 0.2.2 - #48
Merged
Conversation
The half of the 0.2.2 sync that had to wait for the engine release. `embed_norm_eps` widens BaseRTModelConfig from 1540 to 1704 bytes. The rust-sys ABI job links the latest engine RELEASE from this repo and compares it against the in-tree mirror, so syncing these before v0.2.2 was published failed by construction — 1540 from the binary against 1704 from source. v0.2.2 is now released here, so the two agree. Verified the way that job does it: downloaded basert-engine-macos-arm64-0.2.2.tar.gz from this repo's release, pointed BASERT_LIB_DIR at it, and ran the sys crate — 15 passed, including model_config_size_matches_library, the assertion that previously failed. The mirrors are one ABI struct across C, Swift, Rust, Python and Node; the model config is returned BY VALUE, so a mirror even four bytes short lets the engine write past the caller's allocation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The half of the 0.2.2 sync that had to follow the engine release.
embed_norm_epswidensBaseRTModelConfigfrom 1540 to 1704 bytes. Therust-sys ABIjob links the latest engine release from this repo and compares it against the in-tree mirror, so syncing these while v0.2.1 was newest failed by construction (1540 from the binary vs 1704 from source). v0.2.2 is now released here, so they agree.Verified locally the way that job does it — downloaded
basert-engine-macos-arm64-0.2.2.tar.gzfrom this repo's release, setBASERT_LIB_DIR, ran the sys crate: 15 passed, includingmodel_config_size_matches_library.Six files, one ABI struct across C, Swift, Rust, Python and Node. The model config is returned by value, so a mirror even four bytes short lets the engine write past the caller's allocation.
Completes the 0.2.2 open-core sync; the converter and catalog landed in #47.