Add command to delete saved wallet config by yan-pi · Pull Request #312 · bitcoindevkit/bdk-cli

yan-pi · 2026-08-06T17:21:42Z

Description

Adds wallets delete <wallet_name> to remove a saved wallet configuration.
Saved configurations can be listed with wallets list.

Resolves #310.

Notes to the reviewers

List and delete use separate handlers and outputs.

Delete only removes the entry from config.toml.
Wallet database files arenot removed.

Changelog notice

Added wallets delete to remove a saved wallet configuration

Checklists

All Submissions:

I've signed all my commits
I followed the contribution guidelines
I ran cargo fmt and cargo clippy before committing

New Features:

I've added tests for the new feature
I've added docs for the new feature
I've updated CHANGELOG.md

tvpeter · 2026-08-07T08:59:08Z

Only the config.toml entry is affected, wallet data on disk is not touched (dont know if its the correct path).

So wallet config only writes config.toml. The DB file is created lazily during an actual wallet operation. So deleting a config that was never used leaves nothing on disk. However, if the wallet was used, the DB file remains.

tvpeter

I agree with the approach of the delete operation but the returned type of WalletList is unnecesary. If returning a message is not possible, then it is better to split the wallets into something like wallets list and wallets --delete <name>. So WalletsSubcommand will be the top-level.

tvpeter · 2026-08-07T08:31:09Z

 #[derive(Args, Debug, Clone, PartialEq)]
-pub struct ListWalletsCommand;
+pub struct WalletsCommand {
+    /// Delete the saved configuration for the given wallet instead of listing.


Suggested change

/// Delete the saved configuration for the given wallet instead of listing.

/// Delete the saved configuration for the given wallet.

tvpeter · 2026-08-07T08:53:07Z


-    /// List all saved wallet configurations.
-    Wallets(ListWalletsCommand),
+    /// List all saved wallet configurations, or delete one with `--delete`.


Suggested change

/// List all saved wallet configurations, or delete one with `--delete`.

/// Saved wallet configuration operations.

vadim-anfv

cACK e987877

Thanks for picking this up. I left a couple of non-blocking comments inline, both of which fold naturally into the wallets list / wallets delete restructure @tvpeter asked for.

vadim-anfv · 2026-08-07T16:34:04Z

+                    "Wallet '{wallet_name}' not found in config"
+                )));
+            }
+            config.save(&ctx.datadir)?;


Non-blocking: deleting the last wallet leaves config.toml with an empty wallets table, a state that was unreachable before --delete. WalletConfig::load returns None only when the file is missing, so wallets then prints {} and exits 0, while the same situation on a fresh datadir fails with "No wallets configured yet." and a non-zero exit (test_list_wallets_empty).

Probably worth folding into the wallets list / wallets delete split you are doing anyway.

vadim-anfv · 2026-08-07T16:58:07Z

+        WalletConfigInner {
+            wallet: name.to_string(),
+            network: "testnet".to_string(),
+            ext_descriptor: EXT_DESCRIPTOR.to_string(),
+            int_descriptor: Some(INT_DESCRIPTOR.to_string()),
+            #[cfg(any(feature = "sqlite", feature = "redb"))]
+            database_type: "sqlite".to_string(),
+            #[cfg(any(
+                feature = "electrum",
+                feature = "esplora",
+                feature = "rpc",
+                feature = "cbf"
+            ))]
+            client_type: Some("rpc".to_string()),
+            #[cfg(any(feature = "electrum", feature = "esplora", feature = "rpc"))]
+            server_url: Some("http://localhost:18443".to_string()),
+            #[cfg(feature = "electrum")]
+            batch_size: None,
+            #[cfg(feature = "esplora")]
+            parallel_requests: None,
+            #[cfg(feature = "rpc")]
+            rpc_user: None,
+            #[cfg(feature = "rpc")]
+            rpc_password: None,
+            #[cfg(feature = "rpc")]
+            cookie: None,
+            #[cfg(any(feature = "electrum", feature = "esplora"))]
+            proxy: None,
+            #[cfg(any(feature = "electrum", feature = "esplora"))]
+            proxy_auth: None,
+            #[cfg(any(feature = "electrum", feature = "esplora"))]
+            proxy_retries: None,
+            #[cfg(any(feature = "electrum", feature = "esplora"))]
+            proxy_timeout: None,
+            #[cfg(feature = "cbf")]
+            conn_count: None,
+        }


Nit: test_wallet_config_inner_to_opts_conversion and test_invalid_client_type_fails still build WalletConfigInner by hand, repeating the same ~20 cfg-gated fields as the new helper.

Since you are adding a helper anyway, consider turning it into a small builder and reusing it there too - those two only differ in a few values. Fine to leave for a follow-up.

The helper is gone in the updated version. The delete path is covered by the
integration tests instead.

yan-pi · 2026-08-09T19:48:40Z

@tvpeter, that makes sense. Splitting the operations would also fix the return type issue.

Just to confirm, should this become wallets list and wallets delete <name>, as @vadim-anfv suggested?

tvpeter · 2026-08-10T09:23:04Z

@tvpeter, that makes sense. Splitting the operations would also fix the return type issue.

Just to confirm, should this become wallets list and wallets delete <name>, as @vadim-anfv suggested?

Yes. We both said the same thing.

github-project-automation Bot added this to BDK-CLI Aug 6, 2026

yan-pi force-pushed the feat/wallets-delete branch from 9c25d3d to e987877 Compare August 6, 2026 18:06

yan-pi changed the title ~~feat(wallet): add wallets --delete to remove saved wallet config~~ Add wallets --delete to remove saved wallet config Aug 6, 2026

tvpeter assigned yan-pi Aug 6, 2026

tvpeter requested changes Aug 7, 2026

View reviewed changes

vadim-anfv reviewed Aug 7, 2026

View reviewed changes

yan-pi force-pushed the feat/wallets-delete branch from e987877 to 011390e Compare August 11, 2026 17:23

yan-pi changed the title ~~Add wallets --delete to remove saved wallet config~~ Add command to delete saved wallet config Aug 11, 2026

yan-pi added 2 commits August 11, 2026 16:08

feat(wallet): add saved config list and delete commands

fcd2a19

docs: document saved wallet config commands

f2a7e8f

yan-pi force-pushed the feat/wallets-delete branch from 011390e to f2a7e8f Compare August 11, 2026 19:47

Navigation Menu

Uh oh!

Add command to delete saved wallet config - #312

Add command to delete saved wallet config#312
yan-pi wants to merge 2 commits into
bitcoindevkit:masterfrom
yan-pi:feat/wallets-delete

yan-pi commented Aug 6, 2026 •

edited

Loading

Uh oh!

tvpeter commented Aug 7, 2026

Uh oh!

tvpeter left a comment

Uh oh!

tvpeter Aug 7, 2026

Uh oh!

tvpeter Aug 7, 2026

Uh oh!

vadim-anfv left a comment

Uh oh!

vadim-anfv Aug 7, 2026

Uh oh!

vadim-anfv Aug 7, 2026

Uh oh!

yan-pi Aug 11, 2026

Uh oh!

yan-pi commented Aug 9, 2026

Uh oh!

tvpeter commented Aug 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	/// Delete the saved configuration for the given wallet instead of listing.
	/// Delete the saved configuration for the given wallet.

	/// List all saved wallet configurations, or delete one with `--delete`.
	/// Saved wallet configuration operations.

Uh oh!

Conversation

yan-pi commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

New Features:

Uh oh!

tvpeter commented Aug 7, 2026

Uh oh!

tvpeter left a comment

Choose a reason for hiding this comment

Uh oh!

tvpeter Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

tvpeter Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

vadim-anfv left a comment

Choose a reason for hiding this comment

Uh oh!

vadim-anfv Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

vadim-anfv Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

yan-pi Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

yan-pi commented Aug 9, 2026

Uh oh!

tvpeter commented Aug 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yan-pi commented Aug 6, 2026 •

edited

Loading