SP-2354: Add export and import bookmarks commands - #404
Merged
Roberto Welzel Filho (roberto-welzel) merged 6 commits intoAug 7, 2026
Conversation
Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
Roberto Welzel Filho (roberto-welzel)
requested a review
from a team
as a code owner
August 7, 2026 10:48
Replace `any` types with proper interfaces for bookmarks API methods, prefix unused `command` parameter with underscore, use template literal for string interpolation, and add error path tests plus module registration tests to reach coverage threshold. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
Refactor API methods to use idiomatic try/catch with await instead of .catch() chains, and pass the original error as cause to FatalError for proper error chain preservation. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
Mark class members as readonly and use toHaveLength() assertions in tests for better error reporting. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
Drop { cause: e } from FatalError constructors to stay
consistent with the pattern used across the rest of the
codebase.
Includes-AI-Code: true
Co-authored-by: Cursor <cursoragent@cursor.com>
Thomas Neumüller (tneum-celonis)
previously approved these changes
Aug 7, 2026
Thomas Neumüller (tneum-celonis)
left a comment
Thomas Neumüller (tneum-celonis)
left a comment
Contributor
There was a problem hiding this comment.
Alexander Probst (alex-probst)
previously approved these changes
Aug 7, 2026
Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
Roberto Welzel Filho (roberto-welzel)
dismissed stale reviews from Alexander Probst (alex-probst) and Thomas Neumüller (tneum-celonis)
via
August 7, 2026 13:16
09db219
|
Thomas Neumüller (tneum-celonis)
approved these changes
Aug 7, 2026
Roberto Welzel Filho (roberto-welzel)
deleted the
sp-2354-export-import-bookmarks
branch
August 7, 2026 13:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
export bookmarksandimport bookmarkscommands that wrap the package-manager bookmark batch APIs. These are used by the content-deployment-pipeline to copy bookmarks during T2TC.Relevant links
Checklist
Made with Cursor