Skip to content

Add imagePullSecrets to template - #64

Open
mpsOxygen wants to merge 3 commits into
cert-manager:masterfrom
mpsOxygen:master
Open

Add imagePullSecrets to template#64
mpsOxygen wants to merge 3 commits into
cert-manager:masterfrom
mpsOxygen:master

Conversation

@mpsOxygen

Copy link
Copy Markdown

Hello,

This PR adds imagePullSecrets to default values.yaml and deployment.yaml.

Razvan Valceanu added 2 commits April 1, 2024 09:50
Signed-off-by: Razvan Valceanu <razvan.valceanu@metaminds.com>
Signed-off-by: Razvan Valceanu <razvan.valceanu@metaminds.com>
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Apr 1, 2024
@jetstack-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshvanl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 1, 2024
@jetstack-bot

Copy link
Copy Markdown
Contributor

Hi @mpsOxygen. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2024
@wallrj
wallrj requested a lite review from Copilot August 10, 2026 13:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Helm chart support for configuring Kubernetes imagePullSecrets so deployments can pull images from private registries via values configuration.

Changes:

  • Introduces a top-level imagePullSecrets value (defaulting to an empty list) in values.yaml.
  • Conditionally renders spec.template.spec.imagePullSecrets in the Deployment template when configured.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
deploy/example-webhook/values.yaml Adds a default imagePullSecrets: [] value for chart consumers.
deploy/example-webhook/templates/deployment.yaml Conditionally injects imagePullSecrets into the pod spec based on values.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread deploy/example-webhook/templates/deployment.yaml Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: mpsOxygen <undercover_black_hat@yahoo.com>
@cert-manager-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshvanl for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants