Add imagePullSecrets to template - #64
Conversation
Signed-off-by: Razvan Valceanu <razvan.valceanu@metaminds.com>
Signed-off-by: Razvan Valceanu <razvan.valceanu@metaminds.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @mpsOxygen. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Pull request overview
This PR adds Helm chart support for configuring Kubernetes imagePullSecrets so deployments can pull images from private registries via values configuration.
Changes:
- Introduces a top-level
imagePullSecretsvalue (defaulting to an empty list) invalues.yaml. - Conditionally renders
spec.template.spec.imagePullSecretsin the Deployment template when configured.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| deploy/example-webhook/values.yaml | Adds a default imagePullSecrets: [] value for chart consumers. |
| deploy/example-webhook/templates/deployment.yaml | Conditionally injects imagePullSecrets into the pod spec based on values. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: mpsOxygen <undercover_black_hat@yahoo.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Hello,
This PR adds imagePullSecrets to default values.yaml and deployment.yaml.