-
Notifications
You must be signed in to change notification settings - Fork 2
Sort submissions by metadata count #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jerbaroo
wants to merge
18
commits into
master
Choose a base branch
from
jerbaroo-faster-prefer-distinct
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
db1de29
SQL: Filter already reserved chunks from `Chunk` selection
ReinierMaas a6664b3
Add failing PreferDistinct fairness test
jerbaroo ada8709
PreferDistinct sorts submissions by metadata
jerbaroo b40b106
fixup! PreferDistinct sorts submissions by metadata
jerbaroo 31cf874
fixup! PreferDistinct sorts submissions by metadata
jerbaroo 7c1d688
fixup! PreferDistinct sorts submissions by metadata
jerbaroo c903fb1
SQL: Prevent duplicated binds
ReinierMaas 7dfef50
fixup! SQL: Filter already reserved chunks from `Chunk` selection
jerbaroo b48dd48
SQL: Add metadata count FFI function
ReinierMaas 573b2d6
fixup! SQL: Add metadata count FFI function
jerbaroo 1d2f36a
Flatten PreferDistinct into a single query level
jerbaroo 02fc44d
fixup! Flatten PreferDistinct into a single query level
jerbaroo 98f022d
SQL: Deduplicate FFI calls per distinct metadata value
jerbaroo efe45e2
SQL: Single FFI call
jerbaroo 3d9f2c3
Break ties of PreferDistinct submissions with equal counts
jerbaroo 4887d3d
fixup! SQL: Add metadata count FFI function
jerbaroo 7903f8b
fixup! fixup! PreferDistinct sorts submissions by metadata
jerbaroo d644aa5
fixup! fixup! fixup! PreferDistinct sorts submissions by metadata
jerbaroo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just thinking, does our new strategy selection retain randomness if a client reserves multiple chunks in one go? Do we care for that or would documenting the multi-chunk reservation behaviour be enough?