Restore the document metadata dropped when the pages were ported - #575
Merged
Conversation
Parent 26 keeps Spotless away from src/site/markdown. Its flexmark formatter rewrites the fence that closes a YAML front matter block, which silently costs each page its title, author and date.
The APT and xdoc sources carried a title, an author and a date. The conversion to Markdown dropped them, so the generated pages lost their <title> and their author meta. Put them back as YAML front matter. migration-guide.md is left alone: it was authored as Markdown and never had metadata to restore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocked by the release of plexus parent 26.
The APT sources carried a title, an author and a date. Converting the pages to Markdown
dropped them, so every generated page lost its
<title>and its author meta. This putsthem back as YAML front matter.
It could not be done before now. Parent 25 runs Spotless over
**/*.md, and flexmarkrewrites the fence that closes a front matter block into a setext underline, which costs
the page exactly the metadata being restored — silently, with a green build. Parent 26
excludes
**/src/site/markdown/**, so the first commit here is the parent upgrade.Verified after the bump: the front matter survives the build and the generated pages carry
both title and author.
migration-guide.mdis deliberately untouched — it was authored as Markdown and never hadmetadata to restore; only
location-tracking.aptandrelease-notes.aptexisted as APT.