Skip to content

Fix sub_results iteration in the skills examples - #476

Open
ling-senpeng13 wants to merge 1 commit into
mainfrom
fix/skills-examples-sub-results
Open

Fix sub_results iteration in the skills examples#476
ling-senpeng13 wants to merge 1 commit into
mainfrom
fix/skills-examples-sub-results

Conversation

@ling-senpeng13

@ling-senpeng13 ling-senpeng13 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

sub_results is a dict keyed by agent name rather than object list, so iterating it yields strings. 32_skills_multi_agent.py parallel died on the print — PARALLEL is the strategy that actually populates it:

AttributeError: 'str' object has no attribute 'status'

src/conductor/ai/agents/result.py#L124

    finish_reason: Optional[FinishReason] = None
    error: Optional[str] = None
    events: List["AgentEvent"] = field(default_factory=list)
    sub_results: Dict[str, Any] = field(default_factory=dict)

The other two call sites have the same bug, and survived only because their sub_results was empty.

Verified against a 3.32.0-rc18 server: all 8 modes across both examples complete, and parallel prints all three sub-agent outputs.

sub_results is a dict keyed by agent name, so iterating it yields strings.
32_skills_multi_agent.py parallel died on the print — PARALLEL is the strategy
that actually populates it:

  AttributeError: 'str' object has no attribute 'status'

The other two call sites have the same bug and survived only because their
sub_results was empty. Iterate .items() and print the agent name with its
output.

Verified against a 3.32.0-rc18 server: all 8 modes across both examples now
complete, and parallel prints all three sub-agent outputs.
@ling-senpeng13 ling-senpeng13 self-assigned this Aug 12, 2026
@ling-senpeng13
ling-senpeng13 marked this pull request as ready for review August 12, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant