Properly handle error from ReadPartitionedGroupInfo in UpdatePartitionedGroupInfo - #7766
Open
alexqyle wants to merge 2 commits into
Open
Properly handle error from ReadPartitionedGroupInfo in UpdatePartitionedGroupInfo#7766alexqyle wants to merge 2 commits into
alexqyle wants to merge 2 commits into
Conversation
…nedGroupInfo Signed-off-by: Alex Le <leqiyue@amazon.com>
Signed-off-by: Alex Le <leqiyue@amazon.com>
alexqyle
force-pushed
the
update-partitioned-group-fix
branch
from
August 14, 2026 20:43
15b31b9 to
fca9531
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes a TOCTOU race condition in
UpdatePartitionedGroupInfowhere the error fromReadPartitionedGroupInfowas swallowed with_. When S3 returns a transient error (e.g. throttling with many concurrent compactors),existingPartitionedGroupwould be nil, the existence guard would not fire, and the code would fall through tobkt.Upload()— overwriting an existing partitioned group file with a newCreationTime.The fix captures the error and, if it is not
ErrorPartitionedGroupInfoNotFound, logs it and returns — aborting creation so the group will be retried in the next compaction cycle.Which issue(s) this PR fixes:
NA
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags