Add --skip-managed-config and decouple managed config from --skip-pre… - #321
Open
AarushiShah-db wants to merge 3 commits into
Open
Add --skip-managed-config and decouple managed config from --skip-pre…#321AarushiShah-db wants to merge 3 commits into
AarushiShah-db wants to merge 3 commits into
Conversation
…flight --skip-managed-config (on `ucode configure` and every launcher) ignores the workspace's managed coding-agent config for that run, behaving as though ENABLE_MANAGED_AGENT_CONFIG were unset — it clears the env var for the process, so the single managed_agent_config_enabled() gate short-circuits every managed path (fetch/apply, budget read, MCP registration, the configure reject flow, and the bare-`ucode` agent picker). Per-invocation only. --skip-preflight no longer touches managed config: it now means only "skip the per-launch auth + AI Gateway re-validation." Dropped its cache-instead-of-refresh branch, its budget-read and MCP-registration gating, and the bare-`ucode` "no config to pick an agent" error. Co-authored-by: Isaac
…anaged-config # Conflicts: # src/ucode/cli.py # tests/test_cli.py
The provider-launch e2e tests only prove routing reaches the Model Provider Service; a real "Credit balance is too low" from the provider account is an environmental condition, not a ucode bug, so skip it like the existing no-permission case rather than failing CI. Generalize _skip_if_no_permission -> _skip_if_provider_unusable to cover both. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…flight
--skip-managed-config (on
ucode configureand every launcher) ignores the workspace's managed coding-agent config for that run, behaving as though ENABLE_MANAGED_AGENT_CONFIG were unset — it clears the env var for the process, so the single managed_agent_config_enabled() gate short-circuits every managed path (fetch/apply, budget read, MCP registration, the configure reject flow, and the bare-ucodeagent picker). Per-invocation only.--skip-preflight no longer touches managed config: it now means only "skip the per-launch auth + AI Gateway re-validation." Dropped its cache-instead-of-refresh branch, its budget-read and MCP-registration gating, and the bare-
ucode"no config to pick an agent" error.Co-authored-by: Isaac