ucode: require Databricks CLI 1.11.0+ when configuring skills - #322
Open
xsh310 wants to merge 1 commit into
Open
ucode: require Databricks CLI 1.11.0+ when configuring skills#322xsh310 wants to merge 1 commit into
xsh310 wants to merge 1 commit into
Conversation
The skills MCP uploads skill bundles with `databricks fs cp`, which only writes correctly on Databricks CLI v1.11.0 and later (the create then finalize sequence). Before this change `ucode configure skills` inherited the global floor of v1.0.0, so a customer on an older CLI could register the connection and then have uploads silently fail at finalize. Introduce SKILLS_MCP_MIN_DATABRICKS_CLI_VERSION = (1, 11, 0) and enforce it at the top of `configure skills` (both the MCP and download paths, since both register the connection). Parameterize ensure_databricks_cli_version and install_databricks_cli with a `minimum` argument that defaults to the existing global floor, so every other command keeps the v1.0.0 behavior. The existing installer already upgrades transparently, so this is a single automatic upgrade for affected users rather than manual friction. Co-authored-by: Isaac
xsh310
force-pushed
the
skills-mcp-cli-1110-floor
branch
from
August 13, 2026 01:11
a37ce31 to
763381c
Compare
xsh310
marked this pull request as ready for review
August 13, 2026 01:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ucode configure skillscurrently inherits the global Databricks CLI floor of v1.0.0. That floor exists sodatabricks aitoolsis available, but it is too low for the skills MCP: the MCP uploads skill bundles withdatabricks fs cp, whose create then finalize sequence only writes correctly on Databricks CLI v1.11.0 and later. A customer on an older CLI can register the connection and then have uploads silently fail at finalize.This change enforces a v1.11.0 floor specifically for the configure skills command.
What changed
SKILLS_MCP_MIN_DATABRICKS_CLI_VERSION = (1, 11, 0)indatabricks.py.ensure_databricks_cli_version(minimum=...)andinstall_databricks_cli(minimum=...), defaulting to the existing global floor so every other command keeps the v1.0.0 behavior.configure_skillsnow callsinstall_databricks_cli(minimum=SKILLS_MCP_MIN_DATABRICKS_CLI_VERSION)at the top of the command, covering both the--mcpand the download paths since both register the connection.The installer already upgrades transparently, so affected users get a single automatic CLI upgrade rather than a hard failure or manual steps.
Testing
test_cli.py: newtest_requires_skills_mcp_cli_floorasserts the command provisions the CLI with the v1.11.0 floor; autouse fixture stubs the installer for the existing dispatch tests.test_databricks.py: newtest_custom_minimum_upgrades_version_below_itproves a v1.8.0 CLI (which clears the default floor but not the skills floor) triggers an upgrade.tests/test_cli.pyandtests/test_databricks.pypass; ruff clean.Note
The v1.11.0 requirement reflects where
fs cpwrites correctly. The upload itself runs agent side through the skills MCP tools, outside this repo, so please confirm 1.11.0 is the exact fix version before merging.This pull request and its description were written by Isaac.