fix for ipc regressions - #373
Merged
Merged
Conversation
Owner
|
The unit tests are broken :) |
Contributor
Author
|
ok, sorry about that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The caching changes broke the way we opened packs after IPC requests:
Failed loading external pack file K:\SteamLibrary\steamapps\common\Total War WARHAMMER III\data\variants.pack System.InvalidOperationException: The calling thread must be STA, because many UI components require this.Currently we need to load packs using a WPF dispatcher.
WpfUiDispatcher is a small wrapper around Application.Current.Dispatcher that makes the code easier to test.