Skip to content

fix: prevent reward dilution via zero sharesReward harvest #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ishant5436 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: prevent reward dilution via zero sharesReward harvest #808

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
685d874
fix: prevent reward dilution via zero sharesReward harvest
Ishant5436 Jun 17, 2026
7fabf27
fix: restore transferFrom call when sharesReward is zero
Ishant5436 Jun 21, 2026
44add82
chore: update pragma to 0.8.17
Ishant5436 Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contracts/StakedEXA.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,7 @@ contract StakedEXA is
address memProvider = provider;
uint256 shares = Math.min(memMarket.allowance(memProvider, address(this)), memMarket.maxRedeem(memProvider));
uint256 sharesReward = shares.mulWadDown(providerRatio);
if (sharesReward == 0) return;

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Do not skip savings transfer when reward share is zero

This return fires not only when there are no provider shares, but also when providerRatio is 0 or the reward portion rounds down to 0. setProviderRatio permits 0 and the harvest path documents that the non-rewarded portion goes to savings; with a zero ratio, shares can be the provider's full redeemable balance but the function exits before transferring save = shares - sharesReward, so deployments that route all provider funds to savings leave them in the provider indefinitely.

Useful? React with 👍 / 👎.


memMarket.transferFrom(provider, address(this), sharesReward);
uint256 save = shares - sharesReward;
Expand Down