chore(sdk): bump go-flashduty to v0.10.0 and regenerate - #140
Merged
Conversation
The Response-fields parser only accepted [a-zA-Z0-9_] in a field name, so any flat wire name carrying a dot — session_measure.used_cnt, view.days — failed to match and was silently dropped from the card's response line. A dot there is part of the key, not an indent level.
Adds 23 commands: `monit servicemap` (status, topology, summary, fleet,
fleet-summary), `rum error-ingestion-rules` and `rum issue-preset-severity-rules`
(list/create/update/delete/enable/disable/history-list/history-revert, plus
reorder on the latter), and `rum resource-info`.
Removes `rum facet-list`: POST /rum/facet/list is not implemented by any
service and is gone from the SDK. Use `rum field-list --data '{"is_facet":true}'`,
which returns the same field definitions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the SDK's new operations and regenerates the command surface and skill cards.
Added — 23 commands
monit servicemap:status,topology,summary,fleet,fleet-summaryrum error-ingestion-rules:list,create,update,delete,enable,disable,history-list,history-revertrum issue-preset-severity-rules: the same set plusreorderrum resource-infoRemoved —
rum facet-listPOST /rum/facet/listis not implemented by any service and no longer exists in the SDK.rum field-list --data '{"is_facet":true}'returns the same field definitions.Also fixes a card-generator bug
rum resource-infois the first command whose response carries dotted wire names (session_measure.used_cnt,view.days). The Response-fields parser's name class excluded., so those fields were silently dropped from the generated card line — the cross-check against real command help caught it. Fixed with a regression test; no existing card changes as a result.Gates:
make check(fmt, lint,go test -race ./..., build) andmake check-cardsall pass.