feat(build): Support dSYMs with IPA uploads - #3393
Conversation
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0e998bd. Configure here.
|
|
||
| if bundles.is_empty() && allow_wrapper && directories.len() == 1 { | ||
| return discover_dsym_bundles(&directories[0], false); | ||
| } |
There was a problem hiding this comment.
ZIP dSYM discovery skips extra folders
Medium Severity
--dsym ZIP discovery only unwraps a directory when it is the sole top-level folder. A ZIP of a dSYM folder that also contains another directory, such as __MACOSX from Finder compress, yields no bundles and fails even though valid .dSYM bundles are present. That layout matches the documented ZIP-of-a-directory case and is common on macOS, where this feature runs.
Reviewed by Cursor Bugbot for commit 0e998bd. Configure here.
1 participant
Adds support for a new
--dsymoption when uploading IPA files through thebuildcommand. This allows clients to associate app debug symbols with an IPA upload (which typically does not include them). Internally the uploader follows the existing logic to construct a synthetic XCArchive, but will copy the specified dSYM bundles it finds into that archive before uploading. This will give clients a better experience when they upload builds that have undergone "app thinning" since they will not have to perform the synthetic archive construction themselves.Refs EME-1285